Start showing water labels earlier #2864
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthijsmelissen
approved these changes
Sep 24, 2017
kocio-pl
force-pushed
the
water-labels-lowzoom
branch
from
92167a9 to
5d119ab
Compare
kocio-pl
changed the title
This was referenced Sep 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2847.
Current code is incomplete, there is something missing to show labels fromtext-poly-low-zoomlayer.Water labels are safe to render earlier, because they already have to be big (at least 3000 px), so they could start showing along with water areas. This is in general to fix biggest lakes missing labels until zooming into them, as shown on the issue ticket:
Great Lakes
z6
However other big lakes would be better this way, especially where there are no other interesting things around (labels in red just for testing):
Lake Segozero area
z9
There can be also some other big water areas, which would benefit from this change, like water=reservoir:
Rybinsk Reservoir
z9