-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Network names with a space are not being saved correctly #6
Comments
Oops - I was not aware that the WebUI is escaping space characters. Will fix in the next commit. |
@terjeio the doc was not well formated to markdown so information was not really visible - sorry |
@ithinkido Spaces is hostnames are not allowed according to RFC1123, I may add validation later. mDNS discovery breaks if present. |
The new fix allows me to use the network name with the space. Thanks |
Describe the bug
Saving network names which include a space is not working when using webUI for grblHAL
To Reproduce
Expected behavior
The name in this case is "FRITZ!box 7530".
Screenshots
ESP3D Firmware
Target Firmware
Board used
Browser used
Additional context
When exporting the json config file it seems as though the name is correctly listed
Looking at the reply for
[ESP400]
it seems like grblHAL may not be saving the name correctly.The text was updated successfully, but these errors were encountered: