Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network names with a space are not being saved correctly #6

Closed
ithinkido opened this issue Oct 6, 2022 · 4 comments
Closed

Network names with a space are not being saved correctly #6

ithinkido opened this issue Oct 6, 2022 · 4 comments

Comments

@ithinkido
Copy link

Describe the bug
Saving network names which include a space is not working when using webUI for grblHAL

To Reproduce

  1. Select network mode - Access Point / Station
  2. Select a network name which includes a space
  3. Save changes
  4. Reset board
  5. Go back to setting page and check if name was correctly saved

Expected behavior
The name in this case is "FRITZ!box 7530".

Screenshots

image

ESP3D Firmware

Target Firmware

Board used

  • MCU: ESP32
  • Flash size: 4M: 2M/2M

Browser used

  • Name: Firefox
  • Version 105.0.1 (64-bit)
  • Operating system Windows 10

Additional context
When exporting the json config file it seems as though the name is correctly listed

{
    "id": "74",
    "label": "WiFi Station (STA) SSID",
    "value": "FRITZ!Box 7530"
   },

Looking at the reply for [ESP400] it seems like grblHAL may not be saving the name correctly.

[ESP400]
.....
.....
....
{
   "F": "WiFi/WiFi",
   "P": "74",
   "T": "S",
   "V": "FRITZ!Box\\",
   "H": "WiFi Station (STA) SSID",
   "S": "64"
  },
....
....
@terjeio
Copy link
Contributor

terjeio commented Oct 7, 2022

Oops - I was not aware that the WebUI is escaping space characters. Will fix in the next commit.

@luc-github
Copy link

@terjeio the doc was not well formated to markdown so information was not really visible - sorry
I have just added the 3 spaces to make LF in conventions:
https://github.com/luc-github/ESP3D-WEBUI/blob/3.0/Memo/Commands.md

@terjeio
Copy link
Contributor

terjeio commented Oct 7, 2022

@ithinkido Spaces is hostnames are not allowed according to RFC1123, I may add validation later. mDNS discovery breaks if present.
@luc-github options for enabling mDNS and SSDP is on the way up now.

@ithinkido
Copy link
Author

The new fix allows me to use the network name with the space. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants