Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor issue with PROBE_ENABLE==0 #83

Closed
wiersmapa opened this issue Mar 1, 2024 · 2 comments
Closed

Minor issue with PROBE_ENABLE==0 #83

wiersmapa opened this issue Mar 1, 2024 · 2 comments

Comments

@wiersmapa
Copy link

I disabled the optional probe in a custom my_machine.h (#define PROBE_ENABLE 0 on line 84). The build failed as It exposes an undeclared probeConfigure() on line 1994 of driver.c. Definition of probeConfigure() (line 1240) is only done if PROBE_PIN is declared (e.g. generic_map line 106) which is dependent on PROBE_ENABLE. Enabling the (unused) probe allowed the build to work. Not sure if enabling the probe (on an unused input pin) would cause other issues.

@terjeio
Copy link
Contributor

terjeio commented Mar 1, 2024

Which driver? RP2040?

@wiersmapa
Copy link
Author

wiersmapa commented Mar 1, 2024 via email

@terjeio terjeio transferred this issue from grblHAL/core Mar 1, 2024
terjeio added a commit that referenced this issue Mar 19, 2024
Updated for core change related to the RGB HAL.
@terjeio terjeio closed this as completed Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants