Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recursively calling onSpindleProgrammed() #20

Closed
dresco opened this issue Jan 6, 2025 · 1 comment
Closed

Recursively calling onSpindleProgrammed() #20

dresco opened this issue Jan 6, 2025 · 1 comment

Comments

@dresco
Copy link
Contributor

dresco commented Jan 6, 2025

Just working through the spindle encoder functionality in H7 driver..

Is attempting to set on_spindle_programmed twice here a bug?

For me this results in both on_spindle_programmed & grbl.on_spindle_programmed pointing at onSpindleProgrammed(), which is just called recursively here until hard fault from stack corruption.
@terjeio
Copy link
Contributor

terjeio commented Jan 6, 2025

Likely a copy/paste error - forgetting to delete bad code when copying from the F4 driver...
Will fix in the next commit.

terjeio added a commit that referenced this issue Jan 7, 2025
@terjeio
Increased reset delay for WizNet ethernet modules.
5faad09 
Fixed regression affecting step injection, used when stepper spindle or plasma THC is enabled.
Removed code left over from copy/paste update. Ref. issue #20.
@terjeio terjeio closed this as completed Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dresco @terjeio