Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On RP2040: $help reports two double-word topics, but "$help Control signals" gives no response (whereas "$help Control" IS responsive) #664

Closed
TPMoyer opened this issue Jan 23, 2025 · 1 comment

Comments

@TPMoyer
Copy link

TPMoyer commented Jan 23, 2025

The two double-word topics ("Control signals" and "Tool change") reported by $help do not work as "$help topicNameHere".
One might:

  1. change the topics reported by $help to include only single word topics (ControlSignals and ToolChange) to match the setting_detail_t entries in settings.c
    or
  2. modify the report.c to trim the XXX in $help XXX to be only a single word, then parse the "$help topic" response based thereupon.

One might also wish to futureproof against what might turn out to be an unintentionally set trap.
This is related to the CamelCaps implementations of the topics reported, and their AllMoSt matching entries in the setting_detail_t instantiations.
Control signals
Tool change
vs the setting_detail_t entries in settings.c as
Group_ControlSignals
Group_Toolchange

Control signals might become ControlSignals
Tool change might become ToolChange
Group_Toolchange might become Group_ToolChange

terjeio added a commit that referenced this issue Jan 24, 2025
…#664.

Improved default serial port mapping when both MPG mode and keypad plugin are enabled to ensure the port is shared.
Delayed status report output on MPG mode change a few milliseconds to avoid awakening the ESP32 guru that sometimes reboots the controller.
@terjeio
Copy link
Contributor

terjeio commented Jan 24, 2025

I went for option 2.

@terjeio terjeio closed this as completed Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants