Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements on Jerk-Accel code #660

Merged
merged 9 commits into from
Jan 18, 2025
Merged

Improvements on Jerk-Accel code #660

merged 9 commits into from
Jan 18, 2025

Conversation

Dietz0r
Copy link
Contributor

@Dietz0r Dietz0r commented Jan 13, 2025

Good Morning, here's the first round of improvements on the jerk acceleration code.

  • fixed segment planner losing last_segmet_accel value between planner passes
  • improved jerk ramp detection for acceleration and deceleration
  • new calculation for effective acceleration over block in planner.c to determine between full jerk ramp movements and partial jerk ramp movements

now works with a wider band of jerk settings, recommended is still at least 10x accel as a starting point. jogging issues have been diminished greatly but might still crop up as taking a long time to finish the jogging move or having an excessive last segment decel for tiny movement blocks

thanks to: @andrewmarles and @mintracer @engigeer @MBaadsgaard @fpq437 on the printNC discord for troubleshooting, testing and theorycrafting coding help

Note:
Could you mark the jerk setting in the webbuilder as actively beta and maybe expose the ACCERLERATIONTICKS_PER_SECOND and SEGMENT_BUFFER option to people that are choosing it? those are kind of necessary to finetune the system

@terjeio
Copy link
Contributor

terjeio commented Jan 18, 2025

Could you mark the jerk setting in the webbuilder as actively beta and maybe expose the ACCERLERATIONTICKS_PER_SECOND and SEGMENT_BUFFER option to people that are choosing it? those are kind of necessary to finetune the system

Can someone create a Wiki page for this? I can give write access for that.

@terjeio terjeio merged commit 31fc78c into grblHAL:master Jan 18, 2025
terjeio added a commit that referenced this pull request Jan 18, 2025
…t) and

new HAL entry point for querying/resetting driver status.
Added driver capability flags and settings, $742 - $745, for enabling and inverting motor warning and fault input signals (per axis).
Improved jerk acceleration. Ref. PR #660.
@Dietz0r
Copy link
Contributor Author

Dietz0r commented Jan 19, 2025

Can someone create a Wiki page for this? I can give write access for that.

i can do that if you want me to explain how the implementation works and how changing the settings affect it? can i use pictures to visualize the points?

@terjeio
Copy link
Contributor

terjeio commented Jan 19, 2025

i can do that if you want me to explain how the implementation works and how changing the settings affect it?

Yes that would be nice. I have opened access now.

can i use pictures to visualize the points?

Sure, there is an images directory that I use for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants