[BUGFIX] Patch inconsistent ordering within GCP test asserts #7130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for niobium-lead-7998 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Shinnnyshinshin
approved these changes
Feb 13, 2023
added 2 commits
February 13, 2023 15:21
| @@ -300,7 +300,12 @@ | |||
| }, | |||
| "out": { | |||
| "success": false, | |||
| "unexpected_index_list": [0], | |||
| "unexpected_index_list": [ | |||
There was a problem hiding this comment.
Updated so that the output includes ID/PK
| "postgresql", | ||
| "mssql", | ||
| "mysql", | ||
| "bigquery" |
There was a problem hiding this comment.
bigquery does not allow for comparison between datetime
Comment on lines
-256
to
+270
| "suppress_test_for": ["pandas", "spark", "postgresql", "mssql", "mysql"], | ||
| "suppress_test_for": [ |
There was a problem hiding this comment.
bigquery does not allow for comparison between datetime
| # Call out supported dialects | ||
| if "pandas_v3_api" in only_for: | ||
| generate_test = True | ||
| if "sqlalchemy" in only_for: |
There was a problem hiding this comment.
This was a bug. The pandas_v3_api should have been in the if statement that was checking for PandasBatchData.
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Shinnnyshinshin
deleted the
b/_/patch_gcp_unexpected_list_sorting_issues
branch
Shinnnyshinshin
pushed a commit
to jmoskovc/great_expectations
that referenced
this pull request
Feb 15, 2023
* develop: [CONTRIB] added new Expectations - India_zip_code expectation and not_to_be_future_date expectation (great-expectations#6086) [MAINTENANCE] Remove unused dockerfile (great-expectations#7152) [DOCS] doc-464 consolidating and standardizing snippets (great-expectations#7154) [BUGFIX] Patch broken rendered content Cloud tests (great-expectations#7155) [MAINTENANCE] Clean up `mypy` violations in `CardinalityChecker` (great-expectations#7146) [MAINTENANCE] Clean up pathlib.Path() usage in DataConnector utilities and restore tighter formatting in great_expectations/util.py (great-expectations#7149) [MAINTENANCE] Change all instances of `create_expectation_suite` to `add_expectation_suite` in tests, docs, and source code (great-expectations#7117) [BUGFIX] Parse pandas version correctly for development builds (great-expectations#7147) [MAINTENANCE] Update V3 DataConnector utilities to support New Datasources (ZEP) (great-expectations#7144) [BUGFIX] Patch inconsistent ordering within GCP test asserts (great-expectations#7130) Refactor sql splitter to take selectable instead of str. (great-expectations#7133)
Shinnnyshinshin
pushed a commit
that referenced
this pull request
Feb 16, 2023
* develop: (29 commits) [BUGFIX] pydantic>=1.10.4 - ImportError: cannot import name dataclass_transform (#7163) [MAINTENANCE] ZEP - update asset factories method signatures from asset models (#7096) Delete cli v012 tests. (#7159) [CONTRIB] added new Expectations - India_zip_code expectation and not_to_be_future_date expectation (#6086) [MAINTENANCE] Remove unused dockerfile (#7152) [DOCS] doc-464 consolidating and standardizing snippets (#7154) [BUGFIX] Patch broken rendered content Cloud tests (#7155) [MAINTENANCE] Clean up `mypy` violations in `CardinalityChecker` (#7146) [MAINTENANCE] Clean up pathlib.Path() usage in DataConnector utilities and restore tighter formatting in great_expectations/util.py (#7149) [MAINTENANCE] Change all instances of `create_expectation_suite` to `add_expectation_suite` in tests, docs, and source code (#7117) [BUGFIX] Parse pandas version correctly for development builds (#7147) [MAINTENANCE] Update V3 DataConnector utilities to support New Datasources (ZEP) (#7144) [BUGFIX] Patch inconsistent ordering within GCP test asserts (#7130) Refactor sql splitter to take selectable instead of str. (#7133) [BUGFIX] `TupleAzureBlobStoreBackend` no longer gives warning when obfuscating connection string (#7139) [MAINTENANCE] ruff 0.0.246 update (#7137) [MAINTENANCE] Output Consistent Data Format from "table.head" Metric for every ExecutionEngine (#7134) [BUGFIX] Copy previous versions after checking out the the current commit (#7142) [DOCS] Remove sitemap.xml (#7141) [MAINTENANCE] mypy `v1.0.0` (#7138) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Definition of Done