Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update formatting for mostly when building docs #811

Merged
merged 7 commits into from
Oct 23, 2019
Merged

Update formatting for mostly when building docs #811

merged 7 commits into from
Oct 23, 2019

Conversation

jcampbell
Copy link
Contributor

No description provided.

@jcampbell jcampbell requested a review from roblim October 18, 2019 16:07
@cla-bot cla-bot bot added the cla-signed label Oct 18, 2019
@coveralls
Copy link

coveralls commented Oct 20, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 79.157% when pulling c44ddf0 on fix/build_docs into 66490d1 on develop.

Aylr
Aylr previously approved these changes Oct 21, 2019
View reviewed changes
@pep8speaks
Copy link

pep8speaks commented Oct 23, 2019 •
edited
Loading

Thank you for submitting to Great Expectations!

Line 94:5: E303 too many blank lines (2)
Line 157:121: E501 line too long (124 > 120 characters)
Line 180:121: E501 line too long (218 > 120 characters)

Line 37:121: E501 line too long (307 > 120 characters)

Line 244:121: E501 line too long (124 > 120 characters)

This linter comment has been updated based on the most recent commit.

Comment last updated at 2019-10-23 22:21:07 UTC

eugmandel
eugmandel previously approved these changes Oct 23, 2019
View reviewed changes
@jcampbell
py2 unicode handling
c44ddf0 
Signed-off-by: James Campbell <[email protected]>
@jcampbell jcampbell merged commit 7b977f3 into develop Oct 23, 2019
@jcampbell jcampbell deleted the fix/build_docs branch October 23, 2019 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eugmandel eugmandel eugmandel left review comments

@Aylr Aylr Aylr left review comments

@roblim roblim Awaiting requested review from roblim

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jcampbell @coveralls @pep8speaks @eugmandel @Aylr