Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few last minute fixes for 0.8.2 - see the description for details #821

Merged
merged 7 commits into from
Oct 22, 2019

Conversation

eugmandel
Copy link
Contributor

@eugmandel eugmandel commented Oct 22, 2019

  1. Fix: the link to the action list validation operator reference page was out of date
  2. Fix in the config version detection logic - check for either validations_store or validations_stores top level keys in the config to determine if this is a 0.7.x
  3. Fix: temporary table names that start with a digit are not allowed (at least in MySQL) - added a ge_tmp_ prefix
  4. Fix: double quotes around the temp table name were failing the execution on MySQL. I could not find a SQLAlchemy way to create a temporary table, so implemented a conditional logic based on the dialect name - not great, but this fixes the issue
  5. Added a couple of details to the docs section on migrating to 0.8.x. Instead of meticulously documenting all the steps of migrating the config file, I put a call to action to get help on Slack

@cla-bot cla-bot bot added the cla-signed label Oct 22, 2019
@pep8speaks
Copy link

pep8speaks commented Oct 22, 2019

Thank you for submitting to Great Expectations!

Line 1866:121: E501 line too long (130 > 120 characters)

Line 58:121: E501 line too long (175 > 120 characters)

Line 126:38: E225 missing whitespace around operator

This linter comment has been updated based on the most recent commit.

Comment last updated at 2019-10-22 18:02:46 UTC

…on on MySQL. I could not find a SQLAlchemy way to create a temporary table, so implemented the ifelse based on the dialect name - not great, but this fixes the issue
…r either validations_store or validations_stores top level keys in the config to determine if this is a 0.7.x
@coveralls
Copy link

coveralls commented Oct 22, 2019

Coverage Status

Coverage decreased (-0.09%) to 79.255% when pulling 6c7eede on eugene/802_fixes_20191021_0 into b91a3ce on develop.

…Instead of meticulously documenting all the steps of migrating the config file, I put a call to action to get help on Slack
@eugmandel eugmandel changed the title WIP - DO NOT LOOK AT ME YET! :) A few last minute fixes for 0.8.2 - see the description for details Oct 22, 2019
@eugmandel eugmandel requested review from jcampbell and Aylr October 22, 2019 17:59
@eugmandel eugmandel merged commit 844e172 into develop Oct 22, 2019
@jcampbell jcampbell deleted the eugene/802_fixes_20191021_0 branch October 25, 2019 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants