-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A few last minute fixes for 0.8.2 - see the description for details #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
eugmandel
commented
Oct 22, 2019
•
edited
Loading
edited
- Fix: the link to the action list validation operator reference page was out of date
- Fix in the config version detection logic - check for either validations_store or validations_stores top level keys in the config to determine if this is a 0.7.x
- Fix: temporary table names that start with a digit are not allowed (at least in MySQL) - added a ge_tmp_ prefix
- Fix: double quotes around the temp table name were failing the execution on MySQL. I could not find a SQLAlchemy way to create a temporary table, so implemented a conditional logic based on the dialect name - not great, but this fixes the issue
- Added a couple of details to the docs section on migrating to 0.8.x. Instead of meticulously documenting all the steps of migrating the config file, I put a call to action to get help on Slack
…s instead of validations_store
…t least in MySQL) - added a ge_tmp_ prefix
Thank you for submitting to Great Expectations!
This linter comment has been updated based on the most recent commit. Comment last updated at 2019-10-22 18:02:46 UTC |
…on on MySQL. I could not find a SQLAlchemy way to create a temporary table, so implemented the ifelse based on the dialect name - not great, but this fixes the issue
…r either validations_store or validations_stores top level keys in the config to determine if this is a 0.7.x
…Instead of meticulously documenting all the steps of migrating the config file, I put a call to action to get help on Slack
jcampbell
approved these changes
Oct 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.