[BUGFIX] scrapy compatibility - handle dir() inconsistencies
#9830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kilo59
changed the title
dir() inconsistenciesdir() inconsistencies
Kilo59
changed the title
dir() inconsistenciesdir() inconsistencies
Kilo59
changed the title
dir() inconsistenciesdir() inconsistencies
Kilo59
changed the title
dir() inconsistenciesscrapy compatibility - handle dir() inconsistencies
NathanFarmer
approved these changes
Apr 29, 2024
anthonyburdi
approved these changes
Apr 29, 2024
Kilo59
added a commit
that referenced
this pull request
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code assumes that all attr names returned by
dir(cls)must actually exist on the class but per official python documentation, this is not guaranteed.https://docs.python.org/3.10/library/functions.html#dir
Dynamic alteration of classes through metaclasses or other methods can result in
dir(cls)returning an attribute that is not retrievable bygetattr()and leads to an error.#9698 (comment)
References