Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firmware: Add support for hardware revision detection #32

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

mndza
Copy link
Contributor

@mndza mndza commented Dec 20, 2023

This PR adds support for performing optional board-specific revision detection at startup.

It also adds Cynthion-specific code for reading the pin straps. This feature only works for Cynthion revisions >=0.6.

@antoinevg antoinevg mentioned this pull request Apr 16, 2024
@mndza mndza force-pushed the board-rev-detect branch from 108eaea to 8882dec Compare May 30, 2024 11:39
@mndza mndza changed the title firmware: Add hardware revision detection firmware: Add support for hardware revision detection May 30, 2024
@mndza mndza force-pushed the board-rev-detect branch 2 times, most recently from 3b85b8d to 7be4f3b Compare May 30, 2024 12:01
@mndza mndza marked this pull request as ready for review May 30, 2024 12:16
@mndza mndza requested a review from mossmann May 30, 2024 12:16
@mndza mndza force-pushed the board-rev-detect branch from 7be4f3b to c19b291 Compare May 30, 2024 12:19
Copy link
Member

@mossmann mossmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me (tested on r1.3.1 and r1.4.0), but I would like to see some changes.

@mndza mndza force-pushed the board-rev-detect branch 2 times, most recently from da8bd63 to 71f9611 Compare May 31, 2024 08:12
Also, add Cynthion-specific code for reading the pin straps. This
feature only works for Cynthion revisions >=0.6.
@mndza mndza force-pushed the board-rev-detect branch from 71f9611 to 6ca82ed Compare May 31, 2024 08:17
@mndza mndza requested a review from mossmann June 4, 2024 10:28
Copy link
Member

@mossmann mossmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful! Thank you!

@mossmann mossmann merged commit b0ee905 into greatscottgadgets:main Jun 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants