Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firmware: Use Base32 for the serial number in SAMD11/SAMD21 boards #37

Merged
merged 2 commits into from
Mar 25, 2024
Merged

firmware: Use Base32 for the serial number in SAMD11/SAMD21 boards #37

merged 2 commits into from
Mar 25, 2024

Conversation

mndza
Copy link
Contributor

@mndza mndza commented Feb 16, 2024

Makes the serial number consistent with Saturn-V.

@mndza mndza mentioned this pull request Feb 16, 2024
Closed
martinling
martinling requested changes Mar 7, 2024
View reviewed changes
Copy link
Member

@martinling martinling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should arrange for this code not to be duplicated across boards.

@mndza mndza marked this pull request as draft March 8, 2024 07:31
@martinling martinling mentioned this pull request Mar 11, 2024
Merged
@mndza
firmware: Use Base32 for the serial number in SAMD11/SAMD21 boards
4a14ca6 
Makes the serial number consistent with Saturn-V.
@mndza mndza marked this pull request as ready for review March 12, 2024 12:37
@mndza mndza requested a review from martinling March 12, 2024 12:38
martinling
martinling approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@martinling martinling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good. Integrated and tested on cynthion-test.

@martinling martinling merged commit d497b06 into greatscottgadgets:master Mar 25, 2024
3 checks passed
@antoinevg antoinevg mentioned this pull request Apr 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinling martinling martinling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mndza @martinling