Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename honor_fpga_adv to allow_fpga_takeover_usb #51

Merged
merged 1 commit into from
May 16, 2024
Merged

rename honor_fpga_adv to allow_fpga_takeover_usb #51

merged 1 commit into from
May 16, 2024

Conversation

mndza
Copy link
Contributor

@mndza mndza commented May 9, 2024

No description provided.

@mndza mndza requested a review from mossmann May 9, 2024 07:58
@martinling
Copy link
Member

This will need a change in the Cynthion repo too, as we call this in toolchain_prepare and toolchain_program.

@mndza
Copy link
Contributor Author

mndza commented May 15, 2024

This will need a change in the Cynthion repo too, as we call this in toolchain_prepare and toolchain_program.

I anticipated that: greatscottgadgets/cynthion#80

mossmann
mossmann approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@mossmann mossmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. Thank you!

@mossmann mossmann merged commit 93470ec into greatscottgadgets:main May 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mossmann mossmann mossmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mndza @martinling @mossmann