Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration with cVim / Vimium #271

Open
rafi opened this issue Aug 9, 2015 · 19 comments
Open

Integration with cVim / Vimium #271

rafi opened this issue Aug 9, 2015 · 19 comments

Comments

@rafi
Copy link

rafi commented Aug 9, 2015

I'm an avid cVim user, and I love The Great Suspender. However, on suspended tabs, cVim stops working. Is there a way I could keep using both these awesome plugins together?

@tmttn
Copy link

tmttn commented Jan 12, 2016

I was experiencing this issue myself, so I'm glad someone beat me in reporting it. I love both extensions a lot. It would be nice if they'd play nice together.

@kalbasit
Copy link

kalbasit commented Dec 1, 2016

I have the same problem. @deanoemcke is it possible to whitelist extensions so we can whitelist cVim?

@boorac
Copy link

boorac commented Nov 5, 2017

+1 definitely would love this

@deanoemcke
Copy link
Collaborator

Can you give me a bit more information on what is breaking in cVim (specifically)?
The problem is most likely that extensions cannot function on another extensions tab. All suspended tabs belong to the Great Suspender extension. I don't think there is a way to work around this. But I would need a more specific example to be sure.

@deanoemcke
Copy link
Collaborator

The comments on this PR are also quite relevant: #423

I think essentially, they implemented the problematic keyboard shortcuts inside The Great Suspender. Not a solution that I think is really correct..

@deanoemcke deanoemcke changed the title Integration with cVim Integration with cVim / Vimium Nov 27, 2017
@rafi
Copy link
Author

rafi commented Nov 27, 2017

@deanoemcke In a suspended tab, cVim doesn't work at all. You can't even use J/K to navigate through tabs, none of cVim features work.

@kalbasit
Copy link

kalbasit commented Nov 27, 2017

@deanoemcke this could be solved by loading the suspended page externally (as-in accessed via regular http/https) instead of chrome-extension://klbibkeccnjlkjkiokjodocebajanakg/suspended.html. cVim (or any other extension) does not work over chrome-extension://.

@madhukar93
Copy link

bump

@deanoemcke
Copy link
Collaborator

deanoemcke commented Feb 6, 2018

@kalbasit you are correct that the problem could be resolve by using an external web address for suspended tabs. this however makes it dependent on an external site being up (as well as having an internet connection locally). It also significantly affects chrome restart time when restoring a lot of suspended tabs. They currently load almost instantly.
And most importantly, it reduces the extension's performance memory-wise which is the primary use case for the extension.

Unfortunately, I cannot allow this feature request to impact the core performance of the extension :(

@kalbasit
Copy link

kalbasit commented Mar 1, 2018

@deanoemcke could you at least provide an option in the settings allowing us to set a custom URL for the suspended page?

@deanoemcke
Copy link
Collaborator

@kalbasit this would break a lot of functionality. the contents of a suspended tab would be out of my control. it would be a pretty significant code rewrite to implement.

Perhaps you could try my other extension, The Great Discarder. This uses native chrome discarding functionality rather than redirecting to a suspended page. Perhaps it will play nicer with vimium (i haven't tried it sorry).

@dumblob
Copy link

dumblob commented Aug 25, 2018

Perhaps you could try my other extension, The Great Discarder. This uses native chrome discarding functionality rather than redirecting to a suspended page. Perhaps it will play nicer with vimium (i haven't tried it sorry).

Unfortunately starting from Chromium 61.x there is an issue with focusing of discarded tabs. Therefore it doesn't play much nicer with Vimium/cVim 😢.

@jnelson180
Copy link

If you're on a Mac, you can change the shortcuts in System Preferences > Keyboard > Shortcuts and add app specific shortcuts for Chrome. I just use ^J and ^K instead of J and K and it's close-enough-ish.

https://superuser.com/questions/497526/how-to-customize-google-chrome-keyboard-shortcuts

@Eduruiz
Copy link

Eduruiz commented Apr 18, 2019

I have a suggestion here, as a vimium user for a long time and a new user of TGS I's struggling a bit.
So basically the only things I think someone needs to use on a suspended tab is J and K to change tabs, I also notice that TGS already has some keyboard shortcuts that the user can implement (I'm using Ctrl + s to un/suspend tabs, It's not an easy implementation to add the 'next tab' and 'prev tab' shortcuts?

It can have a default to J and K or simply have no defaults and vimium users implement the shortcut by their own.

@dumblob
Copy link

dumblob commented Apr 18, 2019

@Eduruiz that sounds like a good compromise and I raise my hand for that.

@schlowm0
Copy link

schlowm0 commented Mar 24, 2020

Any update on this?

@afedulov
Copy link

It seems that what @Eduruiz is proposing is the best compromise. +1 to it.

@abnerf
Copy link

abnerf commented Sep 18, 2020

Any solutions so far?

@krzkrzkrz
Copy link

I second @Eduruiz suggestion here. Would be great to have this option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests