Add next/prev tab support to match Vimium #423
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it so suspended tabs don't interrupt the Shift+J and Shift+K flow of tab switching in Vimium.
|
Sorry but this is super specific to another extension. I don't think it belongs as part of the code base of this project. You should probably just install a local copy of this extension with your modifications in it. |
|
Is it possible to instead allow user to add keybindings during suspension? |
|
I agree with @deanoemcke. On the other hand I'm a long term user of Vimium and this issue of keybindings not being functional is quite frustrating. @Swoorup, I would say adding keybindings would just bloat the extension. It totally ruins separation of concerns. Is it possible to somehow generally detect any other extension being present on the tab and somehow allow it's functionality? Would "reordering" of the extension execution sequence suffice? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so suspended tabs don't interrupt the Shift+J and Shift+K
flow of tab switching in Vimium.
See philc/vimium#1346