Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stopped working completely with Chrome v46 #312

Closed
PiNotEqual3 opened this issue Oct 16, 2015 · 14 comments
Closed

Stopped working completely with Chrome v46 #312

PiNotEqual3 opened this issue Oct 16, 2015 · 14 comments
Labels

Comments

@PiNotEqual3
Copy link
Contributor

Unfortunately with Chrome v46 this extension stop working completely.

After some debugging I see chrome.windows.getLastFocused({populate: true}, suspendActiveTab); returns the wrong window. Tried to fix it with chrome.windows.getCurrent but that's just the same...

@PiNotEqual3
Copy link
Contributor Author

ok, fixed this by updating backgorund.js with:

//handler for popup clicks
chrome.extension.onRequest.addListener(
    function (request, sender, sendResponse) {

        chrome.tabs.query({ active: true, currentWindow: true }, function(a)
        {
            if (a && a.length)
            {
                var windowID = a[0].windowId;
                if (request.msg === "suspendOne") {
                    chrome.windows.get(windowID, {populate: true}, suspendActiveTab);
                } else if (request.msg === "suspendAll") {
                    chrome.windows.get(windowID, {populate: true}, suspendAllTabs);

                } else if (request.msg === "unsuspendAll") {
                    chrome.windows.get(windowID, {populate: true}, unsuspendAllTabs);
                }
            }
        });
    }
);

PiNotEqual3 added a commit to PiNotEqual3/thegreatsuspender that referenced this issue Oct 16, 2015
getLastFocused returns wrong window with Chrome v46, see greatsuspender#312
@dt-rush
Copy link

dt-rush commented Oct 16, 2015

Strange, it seems to be working for me. Which exact functionality was not working? "Suspend This Tab"?

@dt-rush
Copy link

dt-rush commented Oct 16, 2015

Ah, from looking at the pull request it seems "Suspend Other Tabs" was broken. It's also broken for me at the moment, using Chrome 46 and the The Great Suspender 6.19

@weiweihuanghuang
Copy link

Suspend all tabs doesn't work.
Chrome 46 Suspender 6.21

@PiNotEqual3
Copy link
Contributor Author

@dt-rush Correct. In my old version all functions did not work but in current build only "Suspend Other Tabs" has this problem. I also added "Suspend All Tabs" if someone is interested I can push that, too.

En Taro Adun! ;)

@weiweihuanghuang
Copy link

@PiNotEqual3 i just upgraded from like v4. suspend all tabs is great—it used to be there… was it taken out?

@PiNotEqual3
Copy link
Contributor Author

@weiweihuanghuang It is not in the current master, see popup.html not sure why it was taken out. The function is still named suspendAllTabs() but it is used for "Suspend other tabs"

@weiweihuanghuang
Copy link

@PiNotEqual3 if I change it to:

function suspendAllTabs() {
    chrome.windows.getLastFocused({populate: true}, function(curWindow) {
        curWindow.tabs.forEach(function (tab) {
            requestTabSuspension(tab, true);
        });
    });
}

Should that work?

@PiNotEqual3
Copy link
Contributor Author

@weiweihuanghuang I am not sure if it returns the full window object. Just give it a go ;)

@tnorthcutt
Copy link

Suspend all tabs and Suspend other tabs is working for me.

Chrome 46.0.2490.80 (64-bit)
The Great Suspender 6.21

@lennartcl
Copy link

I was having the same problem with

Chrome 46.0.2490.80 (64-bit)
The Great Suspender 4.74

Not sure why I have this old version or how long that hasn't been updated. The "Update extensions now" button in Chrome wouldn't update it, so I uninstalled and reinstalled it. Problem appears to be gone.

Any reason to believe not updating can be The Great Suspender's fault? Otherwise at least for me it was just caused by using an old version.

@deanoemcke
Copy link
Collaborator

The issue with 'Suspend other tabs' not working has been fixed in the latest release.
@lennartcl You are correct in assuming that it is the extensions fault that it doesn't automatically update. A long time ago I decided that automatically updating the extension was too risky as it removes all suspended tabs from the users browser. Hence, the extension does not automatically update.

@xgdgsc
Copy link

xgdgsc commented Dec 12, 2015

It is right not to auto update, is there an update notification to inform users of new releases?

@deanoemcke
Copy link
Collaborator

This feature is now available in the chrome webstore on v6.30.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants