-
Notifications
You must be signed in to change notification settings - Fork 911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stopped working completely with Chrome v46 #312
Comments
ok, fixed this by updating backgorund.js with:
|
getLastFocused returns wrong window with Chrome v46, see greatsuspender#312
Strange, it seems to be working for me. Which exact functionality was not working? "Suspend This Tab"? |
Ah, from looking at the pull request it seems "Suspend Other Tabs" was broken. It's also broken for me at the moment, using Chrome 46 and the The Great Suspender 6.19 |
Suspend all tabs doesn't work. |
@dt-rush Correct. In my old version all functions did not work but in current build only "Suspend Other Tabs" has this problem. I also added "Suspend All Tabs" if someone is interested I can push that, too. En Taro Adun! ;) |
@PiNotEqual3 i just upgraded from like v4. suspend all tabs is great—it used to be there… was it taken out? |
@weiweihuanghuang It is not in the current master, see popup.html not sure why it was taken out. The function is still named |
@PiNotEqual3 if I change it to:
Should that work? |
@weiweihuanghuang I am not sure if it returns the full window object. Just give it a go ;) |
Chrome 46.0.2490.80 (64-bit) |
I was having the same problem with Chrome 46.0.2490.80 (64-bit) Not sure why I have this old version or how long that hasn't been updated. The "Update extensions now" button in Chrome wouldn't update it, so I uninstalled and reinstalled it. Problem appears to be gone. Any reason to believe not updating can be The Great Suspender's fault? Otherwise at least for me it was just caused by using an old version. |
The issue with 'Suspend other tabs' not working has been fixed in the latest release. |
It is right not to auto update, is there an update notification to inform users of new releases? |
This feature is now available in the chrome webstore on v6.30. |
Unfortunately with Chrome v46 this extension stop working completely.
After some debugging I see
chrome.windows.getLastFocused({populate: true}, suspendActiveTab);
returns the wrong window. Tried to fix it withchrome.windows.getCurrent
but that's just the same...The text was updated successfully, but these errors were encountered: