Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes made in settings tab should be modeless #381

Closed
voxadam opened this issue Apr 4, 2016 · 1 comment
Closed

Changes made in settings tab should be modeless #381

voxadam opened this issue Apr 4, 2016 · 1 comment

Comments

@voxadam
Copy link

voxadam commented Apr 4, 2016

I'd love to see the settings tab for The Great Suspender's settings tab to be made modeless; changes applied immediately on state change.

The problem is that TGS' settings interface consists of multiple sub-tabs. This creates an issue where when a person needs to change a setting that's part of the General settings then switches to the Session management the changes they made in General settings results in any change made in General settings to be lost. Of course the user can click Save settings but that has the effect of closing the settings tab which forces the user to open the settings tab again to continue what they had previously been doing.

Another option would be for TGS to pop dialog asking if they'd like to save their changes when the user selects a different sub-tab (e.g. Keyboard shortcuts). Personally, I nearly always prefer modeless interfaces, especially in the case of configuration interfaces, as it reduces unnecessary dialogs, and buttons. If you are worried users inadvertently making changes and not knowing how to revert them you could replace the Cancel button with something Revert Changes or Discard.

I'd like to tell you how much I love this extension and extend my appreciation to you for developing it. Without TGS I'd have undoubadly thrown my Chromebook with it's measly 4 gigs out the window of a moving vehicle a long time ago which probably wouldn't have turned out well for me or my fellow commuters. Thanks!

ajbarb added a commit to ajbarb/thegreatsuspender that referenced this issue Apr 5, 2016
…tion and a dialog that warns user when options are changed, but save button is not clicked
@deanoemcke
Copy link
Collaborator

This has been implemented. Just a purely modeless view now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants