-
Notifications
You must be signed in to change notification settings - Fork 911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Whitelisting PDFs or by file type #435
Comments
I agree. I also found it suspending jpg/png files and it seems counter intuitive to suspend pages that are fixed assets as it should not be in active memory anyway. |
I found I was able to whitelist pdfs by just adding ".pdf" to the whitelist instead of using a regular expression such as "*.pdf" - I've attached a screenshot as an example. |
@D0nvt possibly a silly question but, are you actually including the square brackets in the whitelist with your example of I have just retested the whitelist for regular expressions and everything seems to work ok? |
@deanoemcke it's possible I was - I haven't fiddled with these setting since around that last post though, and all I ended up leaving was .pdf. In any event, can confirm regexp whitelisting works as given, thanks! |
I'm not sure I agree that it doesn't make sense to suspend pdf tabs. From some testing, a pdf can take up a significant amount of memory. Suspending these tabs will free that memory. I think i'd rather just leave this to be handled by a whitelist regex. |
I encountered a slightly different use case in support of this issue being resolved. |
@mindsocket i think this would be better addressed in a separate issue. something like 'form input not detecting pdf edits'. i am still not convinced that it is worth having something specific in the extension to handle pdfs. |
duplicate of: #257 |
I would like to be able to tell the extension to not suspend PDF's (or any such file types), as they are usually large and redownloading them would be a waste.
Thanks.
The text was updated successfully, but these errors were encountered: