Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitelisting PDFs or by file type #435

Closed
jddcef opened this issue Sep 2, 2016 · 8 comments
Closed

Whitelisting PDFs or by file type #435

jddcef opened this issue Sep 2, 2016 · 8 comments

Comments

@jddcef
Copy link

jddcef commented Sep 2, 2016

I would like to be able to tell the extension to not suspend PDF's (or any such file types), as they are usually large and redownloading them would be a waste.

Thanks.

@mooreaa
Copy link

mooreaa commented Sep 18, 2016

I agree. I also found it suspending jpg/png files and it seems counter intuitive to suspend pages that are fixed assets as it should not be in active memory anyway.

@D0nvt
Copy link

D0nvt commented Nov 29, 2016

I found I was able to whitelist pdfs by just adding ".pdf" to the whitelist instead of using a regular expression such as "*.pdf" - I've attached a screenshot as an example.
However, I was unable to get regular expressions working in general. This is likely a separate issue (or rule input error), but even putting the example regular expression [/^https:.*google.com/] that displays when hovering over the "?" of the whitelist, I don't see any pages whitelisted as a result.

screenshot 2016-11-29 at 11 38 59

@deanoemcke
Copy link
Collaborator

@D0nvt possibly a silly question but, are you actually including the square brackets in the whitelist with your example of [/^https:.*google.com/] ?
This would cause it to fail as the correct form should be /^https:.*google.com/

I have just retested the whitelist for regular expressions and everything seems to work ok?

@D0nvt
Copy link

D0nvt commented Jun 11, 2017

@deanoemcke it's possible I was - I haven't fiddled with these setting since around that last post though, and all I ended up leaving was .pdf. In any event, can confirm regexp whitelisting works as given, thanks!

@deanoemcke
Copy link
Collaborator

I'm not sure I agree that it doesn't make sense to suspend pdf tabs. From some testing, a pdf can take up a significant amount of memory. Suspending these tabs will free that memory.

I think i'd rather just leave this to be handled by a whitelist regex.

@mindsocket
Copy link

I encountered a slightly different use case in support of this issue being resolved.
I had a PDF file with form inputs (different to HTML forms so the setting to leave such things alone didn't kick in), and suspending the tab blew away what had been typed in.

@deanoemcke
Copy link
Collaborator

@mindsocket i think this would be better addressed in a separate issue. something like 'form input not detecting pdf edits'.

i am still not convinced that it is worth having something specific in the extension to handle pdfs.
the usecase of editing a pdf is chrome is fairly uncommon i would say.

@deanoemcke
Copy link
Collaborator

duplicate of: #257
will not fix as whitelisting provides an adequate workaround

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants