Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt processing of evaluated period #265

Merged
merged 2 commits into from
Mar 24, 2021
Merged

Adapt processing of evaluated period #265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f64ba1d
Adapt processing of evaluated period
MaGering Mar 23, 2021
5430372
Update CHANGELOG.md
MaGering Mar 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ Here is a template for new release sections
### Added
-
### Changed
-
- The evaluated period is no longer processed as integer but as float. Hence it is possible to simulate time periods that are for instance shorter than a day (#265)
### Removed
-
### Fixed
Expand Down
2 changes: 1 addition & 1 deletion pvcompare/check_inputs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -519,7 +519,7 @@ def add_evaluated_period_to_simulation_settings(time_series, user_inputs_mvs_dir
mvs_filename="simulation_settings.csv",
mvs_row="evaluated_period",
mvs_column="simulation_settings",
pvcompare_parameter=int(length),
pvcompare_parameter=length,
warning=False,
)

Expand Down
2 changes: 1 addition & 1 deletion tests/test_check_inputs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ def test_add_evaluated_period_to_simulation_settings(self):
file = pd.read_csv(filename, index_col=0, header=0,)

assert (
int(file.at["evaluated_period", "simulation_settings"])
float(file.at["evaluated_period", "simulation_settings"])
== len(ts.index) / 24
)

Expand Down