-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add coveralls test coverage #283
Conversation
as source is stated in rcfile and rcfile has standard name
Locally I can generate a coverage report, which is printed in the terminal. However, on github actions it errors out with
see https://github.com/greco-project/pvcompare/pull/283/checks?check_run_id=2325216239 Discussion also in MVS: rl-institut/multi-vector-simulator#669 |
…o-project/pvcompare into feature/add_coveralls_test_coverage
Open todo after merge of this PR (#283):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Coverage report runs locally for me too. Thank you @SabineHaas
Address #257
Changes proposed in this pull request:
The following steps were realized, as well (required):
EXECUTE_TESTS_ON=master pytest
)Also the following steps were realized (if applies):
Please mark above checkboxes as following:
In case of an error due to linting, run
black . --exclude docs/
and push your changes.Note that in case you do not fix a whole issue you should start your PR with
Address #xyz
.For more information on how to contribute check the CONTRIBUTING.md.