Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add coveralls test coverage #283

Merged
merged 13 commits into from
Apr 15, 2021

Conversation

SabineHaas
Copy link
Collaborator

@SabineHaas SabineHaas commented Apr 12, 2021

Address #257

Changes proposed in this pull request:

  • Test coverage is now automatically checked with github actions and coveralls

The following steps were realized, as well (required):

  • Update the CHANGELOG.md
  • ❌ Check if full simulation tests pass locally (EXECUTE_TESTS_ON=master pytest)

Also the following steps were realized (if applies):

  • Use in-line comments to explain your code
  • Write docstrings to your code
  • For new functionalities: Explain in readthedocs
  • Write test(s) for your new patch of code

Please mark above checkboxes as following:

  • Open
  • Done

In case of an error due to linting, run black . --exclude docs/ and push your changes.
Note that in case you do not fix a whole issue you should start your PR with Address #xyz.

For more information on how to contribute check the CONTRIBUTING.md.

@SabineHaas
Copy link
Collaborator Author

SabineHaas commented Apr 12, 2021

Locally I can generate a coverage report, which is printed in the terminal. However, on github actions it errors out with

Run coverage report -m
No data to report.
Error: Process completed with exit code 1.

see https://github.com/greco-project/pvcompare/pull/283/checks?check_run_id=2325216239

Discussion also in MVS: rl-institut/multi-vector-simulator#669

@SabineHaas
Copy link
Collaborator Author

Open todo after merge of this PR (#283):

  • adapt badge in README.rst

@SabineHaas SabineHaas self-assigned this Apr 15, 2021
@SabineHaas SabineHaas marked this pull request as ready for review April 15, 2021 06:52
@SabineHaas SabineHaas requested a review from MaGering April 15, 2021 06:53
Copy link
Collaborator

@MaGering MaGering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Coverage report runs locally for me too. Thank you @SabineHaas

@SabineHaas SabineHaas merged commit b8a0a0a into dev Apr 15, 2021
@SabineHaas SabineHaas deleted the feature/add_coveralls_test_coverage branch April 15, 2021 12:17
@SabineHaas SabineHaas mentioned this pull request Apr 15, 2021
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants