Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/sim params #299

Merged
merged 3 commits into from
May 4, 2021
Merged

Fix/sim params #299

merged 3 commits into from
May 4, 2021

Conversation

MaGering
Copy link
Collaborator

@MaGering MaGering commented May 3, 2021

With this PR the following parameters are adapted for:

  • Gas provider in energyProviders.csv ( inflow_direction and outflow_direction from Heat bus to Gas bus and energyVector from Heat to Gas)
  • fixcost.csv (age_installed, development_costs, specific_costs_om and specific_costs are neglected in the simulations and hence set to 0. As mentioned by @SabineHaas in PR Update/csvs is #251, setting lifetime to 0 lead to a ZeroDivisionError. To give a hint that the lifetime has been set without higher intentions regarding the value, I chose a lifetime of 1 for all three components)

The following steps were realized, as well (required):

  • Update the CHANGELOG.md
  • Check if full simulation tests pass locally (EXECUTE_TESTS_ON=master pytest)

Also the following steps were realized (if applies):

  • Use in-line comments to explain your code
  • Write docstrings to your code
  • For new functionalities: Explain in readthedocs
  • Write test(s) for your new patch of code

Please mark above checkboxes as following:

  • Open
  • Done

In case of an error due to linting, run black . --exclude docs/ and push your changes.
Note that in case you do not fix a whole issue you should start your PR with Address #xyz.

For more information on how to contribute check the CONTRIBUTING.md.

@MaGering MaGering requested a review from Piranias May 3, 2021 16:32
@Piranias
Copy link
Contributor

Piranias commented May 4, 2021

Still need to adapt the electricity demand regarding the warm water ( see issue #290)

@MaGering
Copy link
Collaborator Author

MaGering commented May 4, 2021

Still need to adapt the electricity demand regarding the warm water ( see issue #290)

No further implementations are needed here (see this comment), so I'll merge this PR now.

@MaGering MaGering merged commit ada5413 into dev May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants