Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setup.py #323

Merged
merged 6 commits into from
May 28, 2021
Merged

Update setup.py #323

merged 6 commits into from
May 28, 2021

Conversation

SabineHaas
Copy link
Collaborator

@SabineHaas SabineHaas commented May 27, 2021

Fix #319, #324

Changes proposed in this pull request:

  • Remove greco_technologies from setup.py
  • Delete if __name__ == "__main__" statements of modules

The following steps were realized, as well (required):

  • Update the CHANGELOG.md
  • Check if full simulation tests pass locally (EXECUTE_TESTS_ON=master pytest)

Also the following steps were realized (if applies):

  • Use in-line comments to explain your code
  • Write docstrings to your code
  • For new functionalities: Explain in readthedocs
  • Write test(s) for your new patch of code

Please mark above checkboxes as following:

  • Open
  • Done

In case of an error due to linting, run black . --exclude docs/ and push your changes.
Note that in case you do not fix a whole issue you should start your PR with Address #xyz.

For more information on how to contribute check the CONTRIBUTING.md.

@SabineHaas SabineHaas requested a review from Piranias May 27, 2021 07:45
@SabineHaas SabineHaas mentioned this pull request May 27, 2021
9 tasks
Copy link
Contributor

@Piranias Piranias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

es fehlen noch demand.py und pv_feedin.py oder? Oder sind die statements da schon weg?

@SabineHaas
Copy link
Collaborator Author

es fehlen noch demand.py und pv_feedin.py oder? Oder sind die statements da schon weg?

da gibt es keine

@SabineHaas SabineHaas merged commit dbb739e into dev May 28, 2021
@SabineHaas SabineHaas deleted the setup/remove_package branch May 28, 2021 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

greco_technologies needed in pvcompare?
2 participants