lf_create_wanpath.py: LAN-3630 - added '--help_summary' support #72
+134
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claplante-candela
assigned claplante-candela and a-gavin and unassigned claplante-candela
py-scripts/lf_create_wanpath.py
Outdated
| epilog='''\ | ||
| Create Wanpaths | ||
| ''', | ||
| description='''\ |
There was a problem hiding this comment.
Nit: Should this maybe be a raw docstring so that the '' don't get eaten in the output?
There was a problem hiding this comment.
I'm also not against removing it entirely. I think the extra spacing is added to center it in the shell when --help is specified (epilogue is the first line above the next prompt)
|
I think this should really be split into two patches: One for the |
|
Agreed with @ct-dylaneskew's feedback. Please separate into two patches and resubmit |
claplante-candela
force-pushed
the
wanpath
branch
from
74c8427 to
ed05669
Compare
Moved parsing out of main, and added validation for required arguments
Verified with:
./lf_create_wanpath.py --mgr 192.168.101.189 --mgr_port 8080\
--wp_name test_wp-A --wl_endp test_wl-A\
--speed 102400 --latency 25 --max_jitter 50 --jitter_freq 6 --drop_freq 12\
--log_level debug --debug
Signed-off-by: Cameron LaPlante <[email protected]>
Added help_summary line and verified. Verified with: ./lf_create_wanpath.py --help_summary Out: This script will create and configure a wanpath given an existing wanlink endpoint. Signed-off-by: Cameron LaPlante <[email protected]>
Removed redundant arg verification and added 'r' in parsing.
Verified with:
./lf_create_wanpath.py --mgr 192.168.101.189 --mgr_port 8080\
--wp_name test_wp-TESTING --wl_endp test_wl-A\
--speed 102400 --latency 25 --max_jitter 50 --jitter_freq 6 --drop_freq 12\
--log_level debug --debug
Signed-off-by: Cameron LaPlante <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected issue where lf_create_wanpath.py did not support help summary and reconfigured argument parsing to be similar to create_station.py.
Verified with:
./lf_create_wanpath.py --help_summary
./lf_create_wanpath.py --mgr 192.168.102.158 --mgr_port 8080
--wp_name test_wp-A --wl_endp test_wl-A
--speed 102400 --latency 25 --max_jitter 50 --jitter_freq 6 --drop_freq 12
--log_level debug --debug