lf_create-wanpath.py: LAN-3133 - Updated arg parsing and added --help_summary support #78
+126
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created parse_args and validate_args functions to clean up main.
Removed argument validation from inside of add_wanpath.
Verified with:
./lf_create_wanpath.py --mgr 192.168.101.189 --mgr_port 8080\
--wp_name test_wp-test --wl_endp test_wl-A\
--speed 102400 --latency 25 --max_jitter 50 --jitter_freq 6 --drop_freq 12\
--log_level debug --debug
./lf_create_wanpath.py --mgr 192.168.101.189 --mgr_port 8080\
--wp_name test_wp-denna\
--speed 102400 --latency 25 --max_jitter 50 --jitter_freq 6 --drop_freq 12\
--log_level debug --debug
Signed-off-by: Cameron LaPlante <[email protected]>
Added response for help_summary flag. Verified with: ./lf_create_wanpath.py --help_summary Out: This script will create and configure a wanpath given an existing wanlink endpoint. Signed-off-by: Cameron LaPlante <[email protected]>
Corrected flake8 complaince.
Added 'r' to comment blocks to preserve '\'.
Verified with:
./lf_create_wanpath.py --mgr 192.168.101.189 --mgr_port 8080\
--wp_name test_wp-test --wl_endp test_wl-A\
--speed 102400 --latency 25 --max_jitter 50 --jitter_freq 6 --drop_freq 12\
--log_level debug --debug
Signed-off-by: Cameron LaPlante <[email protected]>
a-gavin
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated arg parsing/verification to be stand-alone functions outside of main.
Added support for --help_summary flag per LAN-3133.
Signed-off-by: Cameron LaPlante [email protected]