Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Greenbids Bidder adapter #8

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Greenbids Bidder adapter #8

wants to merge 9 commits into from

Conversation

jeremy-greenbids
Copy link

@jeremy-greenbids jeremy-greenbids commented Nov 13, 2024

Type of change

  • New bidder adapter

Description of change

Maintainer: [email protected]

    var adUnits = [{
      code: 'your-slot_1-div', //use exactly the same code as your slot div id.
      sizes: [[300, 250]],
      bids: [{
          bidder: 'greenbids',
          params: { 
              placementId: 12345,
          }
      }]
    },{
      code: 'your-slot_2-div', //use exactly the same code as your slot div id.
      sizes: [[600, 800]],
      bids: [{
          bidder: 'greenbids',
          params: { 
              placementId: 12345,
          }
      }]
    }];

@greenbids greenbids deleted a comment from github-actions bot Nov 13, 2024
@greenbids greenbids deleted a comment from github-actions bot Nov 13, 2024
@greenbids greenbids deleted a comment from github-actions bot Nov 13, 2024
@greenbids greenbids deleted a comment from github-actions bot Nov 13, 2024
Copy link

@sadl3r sadl3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, seems to be a good start 👍

modules/greenbidsBidAdapter.js Outdated Show resolved Hide resolved
modules/greenbidsBidAdapter.js Outdated Show resolved Hide resolved
modules/greenbidsBidAdapter.js Outdated Show resolved Hide resolved
modules/greenbidsBidAdapter.js Show resolved Hide resolved
modules/greenbidsBidAdapter.js Outdated Show resolved Hide resolved
test/spec/modules/greenbidsBidAdapter_specs.js Outdated Show resolved Hide resolved
test/spec/modules/greenbidsBidAdapter_specs.js Outdated Show resolved Hide resolved
test/spec/modules/greenbidsBidAdapter_specs.js Outdated Show resolved Hide resolved
test/spec/modules/greenbidsBidAdapter_specs.js Outdated Show resolved Hide resolved
modules/greenbidsBidAdapter.js Outdated Show resolved Hide resolved
modules/greenbidsBidAdapter.js Outdated Show resolved Hide resolved
modules/greenbidsBidAdapter.js Outdated Show resolved Hide resolved
modules/greenbidsBidAdapter.js Outdated Show resolved Hide resolved
modules/greenbidsBidAdapter.js Outdated Show resolved Hide resolved
Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

@greenbids greenbids deleted a comment from github-actions bot Nov 26, 2024
Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

modules/greenbidsBidAdapter.js Show resolved Hide resolved
modules/greenbidsBidAdapter.js Outdated Show resolved Hide resolved
Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

Copy link

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

Copy link

github-actions bot commented Dec 4, 2024

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants