Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pontos-release] Fix dev-version check in CMake, improve setting dev version after release #135

Merged
merged 5 commits into from
Jun 23, 2021

Conversation

y0urself
Copy link
Member

What:

  • Fix dev-version check in CMakeLists.txt
  • Improve setting dev-version after release

Why:

How:

Checklist:

@y0urself y0urself added the make release To trigger GitHub release action. label Jun 23, 2021
@codecov
Copy link

codecov bot commented Jun 23, 2021

Codecov Report

Merging #135 (942cbb5) into master (a167435) will decrease coverage by 0.85%.
The diff coverage is 52.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #135      +/-   ##
==========================================
- Coverage   90.93%   90.07%   -0.86%     
==========================================
  Files          11       11              
  Lines         783      796      +13     
  Branches      112      117       +5     
==========================================
+ Hits          712      717       +5     
- Misses         47       51       +4     
- Partials       24       28       +4     
Impacted Files Coverage Δ
pontos/version/helper.py 81.81% <ø> (ø)
pontos/version/version.py 79.02% <45.45%> (-3.34%) ⬇️
pontos/version/cmake_version.py 88.61% <66.66%> (-1.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a167435...942cbb5. Read the comment docs.

@y0urself y0urself marked this pull request as ready for review June 23, 2021 09:57
@y0urself y0urself requested a review from a team June 23, 2021 09:57
@nichtsfrei nichtsfrei merged commit 9fdfba4 into master Jun 23, 2021
@nichtsfrei nichtsfrei deleted the y0urself/fix-cmake-dev-version branch June 23, 2021 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
make release To trigger GitHub release action.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants