Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pontos-release] Improve signing #139

Merged
merged 8 commits into from
Jun 24, 2021
Merged

[pontos-release] Improve signing #139

merged 8 commits into from
Jun 24, 2021

Conversation

bjoernricks
Copy link
Contributor

@bjoernricks bjoernricks commented Jun 24, 2021 •
edited
Loading

What:

  • Improve output for errors and downloading assets
  • Use -..asc as filename for signatures
  • Also sign other release assets (tar.gz and zip files)

Why:

  • Use the same naming pattern for signatures as with manual releases before
  • Allow automatically signing of all release files

How:

Checklist:

@bjoernricks
Add output which url is downloaded
3d30602 
Give some feedback if the download takes a bit longer.
@bjoernricks
Improve error message
3f4a658 
Show which url could not be requested. Most likely some parameters are
wrong for example project doesn't fit to the release version.
Without knowing the url such issues are difficult to find.
@bjoernricks
Change names of generated signature files
396bccb 
Use <project>-<version>.<postfix>.asc pattern as name for the signuture
files. This is how we did name the files manually in the past.
@bjoernricks
Also download and sign other assets
8848acb 
* Check for other uploaded release assets
* If there are tarball or zip file assets download and sign them too

This allows easier usage of pontos for GSA where we have some extra
release assets for the node modules.
@bjoernricks bjoernricks requested a review from a team June 24, 2021 06:25
@bjoernricks bjoernricks marked this pull request as draft June 24, 2021 06:25
@codecov
Copy link

codecov bot commented Jun 24, 2021 •
edited
Loading

Codecov Report

Merging #139 (42faae9) into master (4a169b5) will decrease coverage by 1.45%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #139      +/-   ##
==========================================
- Coverage   90.07%   88.61%   -1.46%     
==========================================
  Files          11       11              
  Lines         796      817      +21     
  Branches      117      123       +6     
==========================================
+ Hits          717      724       +7     
- Misses         51       64      +13     
- Partials       28       29       +1
Impacted Files Coverage Δ
pontos/release/helper.py 81.25% <33.33%> (-17.14%) ⬇️
pontos/release/release.py 91.71% <100.00%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a169b5...42faae9. Read the comment docs.

@bjoernricks bjoernricks marked this pull request as ready for review June 24, 2021 06:29
@y0urself y0urself changed the title Improve signing [pontos-release] Improve signing Jun 24, 2021
@y0urself y0urself merged commit 2bc29b4 into master Jun 24, 2021
@y0urself y0urself deleted the improve-signing branch June 24, 2021 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y0urself y0urself y0urself approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjoernricks @y0urself