Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pontos-release] Fix dev version/releasing of Python Projects | Refactor/Move some code #141

Merged
merged 13 commits into from
Jun 24, 2021

Conversation

y0urself
Copy link
Member

@y0urself y0urself commented Jun 24, 2021

What:

  • Fix dev version/releasing of Python Projects
  • You can use both --develop or a version with x.x.x.dev1 to set a develop version

Why:

  • The develop version has not been set correctly before.
  • Make the behavior of C and Python version editing more equal

How:

(.venv) bash-3.2$ pontos-version update --develop 21.6.10.dev1
Version is already up-to-date.
(.venv) bash-3.2$ pontos-version update --develop 21.6.10.dev2
Updated version from 21.6.10.dev1 to 21.6.10.dev2
(.venv) bash-3.2$ pontos-version update --develop 21.6.10.dev1
Updated version from 21.6.10.dev2 to 21.6.10.dev1
(.venv) bash-3.2$ pontos-version update --develop 21.6.10
Version is already up-to-date.

Checklist:

@y0urself y0urself requested a review from a team June 24, 2021 09:06
@y0urself y0urself added the make release To trigger GitHub release action. label Jun 24, 2021
@y0urself y0urself enabled auto-merge June 24, 2021 09:06
@codecov
Copy link

codecov bot commented Jun 24, 2021

Codecov Report

Merging #141 (d3e9906) into master (56a4d58) will decrease coverage by 0.27%.
The diff coverage is 80.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #141      +/-   ##
==========================================
- Coverage   88.41%   88.13%   -0.28%     
==========================================
  Files          11       11              
  Lines         820      826       +6     
  Branches      125      126       +1     
==========================================
+ Hits          725      728       +3     
- Misses         65       68       +3     
  Partials       30       30              
Impacted Files Coverage Δ
pontos/version/cmake_version.py 85.38% <37.50%> (-3.24%) ⬇️
pontos/version/version.py 76.27% <64.70%> (-2.75%) ⬇️
pontos/release/helper.py 79.83% <81.39%> (+0.82%) ⬆️
pontos/release/release.py 91.77% <100.00%> (-0.06%) ⬇️
pontos/version/__version__.py 100.00% <100.00%> (ø)
pontos/version/helper.py 100.00% <100.00%> (+18.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56a4d58...d3e9906. Read the comment docs.

@y0urself y0urself removed the make release To trigger GitHub release action. label Jun 24, 2021
@y0urself y0urself marked this pull request as draft June 24, 2021 09:23
auto-merge was automatically disabled June 24, 2021 09:23

Pull request was converted to draft

@y0urself y0urself marked this pull request as ready for review June 24, 2021 09:32
@y0urself y0urself marked this pull request as draft June 24, 2021 10:02
@y0urself y0urself changed the title [pontos-release] Fix dev version/releasing of Python Projects [pontos-release] Fix dev version/releasing of Python Projects | Refactor/Move some code Jun 24, 2021
@y0urself y0urself marked this pull request as ready for review June 24, 2021 11:06
@y0urself y0urself added the make release To trigger GitHub release action. label Jun 24, 2021
@bjoernricks bjoernricks merged commit 02a966c into master Jun 24, 2021
@bjoernricks bjoernricks deleted the y0urself/fix-develope-version-for-python branch June 24, 2021 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
make release To trigger GitHub release action.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants