Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pontos-update-header option to ignore files #144

Merged
merged 5 commits into from
Jul 2, 2021

Conversation

timopollmeier
Copy link
Member

@timopollmeier timopollmeier commented Jun 24, 2021

What:
The script can be passed a file path or check the directory given with
the --directory option for a .pontos-header-ignore file.
All files matching the paths or globs listed in this filed will be
skipped when adding or updating the headers.

Why:
To allow skipping build directories and other files that should not have a header.

How:
By running the script on a directory with a .pontos-header-ignore file
that has both a normal path and a recursive glob.

Checklist:

@codecov
Copy link

codecov bot commented Jun 24, 2021

Codecov Report

Merging #144 (3b34849) into master (ef40fb8) will decrease coverage by 2.48%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #144      +/-   ##
==========================================
- Coverage   88.13%   85.64%   -2.49%     
==========================================
  Files          11       11              
  Lines         826      871      +45     
  Branches      126      136      +10     
==========================================
+ Hits          728      746      +18     
- Misses         68       90      +22     
- Partials       30       35       +5     
Impacted Files Coverage Δ
pontos/updateheader/updateheader.py 88.88% <50.00%> (-6.65%) ⬇️
pontos/release/helper.py 73.61% <0.00%> (-6.23%) ⬇️
pontos/terminal/terminal.py 97.22% <0.00%> (-2.78%) ⬇️
pontos/release/release.py 90.12% <0.00%> (-1.65%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef40fb8...3b34849. Read the comment docs.

The script can be passed a file path or check the directory given with
the --directory option for .pontos-header-ignore.
All files matching the paths or globs listed in this filed will be
skipped when adding or updating the headers.
@timopollmeier timopollmeier force-pushed the add-header-ignore-file branch from 5f61867 to 4ee2cc3 Compare June 24, 2021 12:36
@timopollmeier timopollmeier marked this pull request as ready for review June 24, 2021 14:08
@timopollmeier timopollmeier requested a review from a team June 24, 2021 14:08
@bjoernricks bjoernricks enabled auto-merge June 24, 2021 20:21
y0urself
y0urself previously approved these changes Jun 29, 2021
pontos/updateheader/updateheader.py Outdated Show resolved Hide resolved
@bjoernricks bjoernricks dismissed stale reviews from y0urself via 3fadf6b June 29, 2021 10:31
pontos/updateheader/updateheader.py Show resolved Hide resolved
pontos/updateheader/updateheader.py Outdated Show resolved Hide resolved
@y0urself y0urself force-pushed the add-header-ignore-file branch 2 times, most recently from 4c8f381 to 3997107 Compare July 2, 2021 10:52
@y0urself y0urself added the make release To trigger GitHub release action. label Jul 2, 2021
@y0urself y0urself marked this pull request as draft July 2, 2021 10:56
auto-merge was automatically disabled July 2, 2021 10:56

Pull request was converted to draft

…glob, so only relative patterns should be used.
@y0urself y0urself force-pushed the add-header-ignore-file branch from 3997107 to 3b34849 Compare July 2, 2021 11:06
@y0urself y0urself marked this pull request as ready for review July 2, 2021 11:06
@bjoernricks bjoernricks merged commit 802fcd5 into master Jul 2, 2021
@bjoernricks bjoernricks deleted the add-header-ignore-file branch July 2, 2021 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
make release To trigger GitHub release action.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants