Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Critical Bug for pontos-release sign, remove debug print. #156

Merged
merged 4 commits into from
Jul 7, 2021

Conversation

y0urself
Copy link
Member

@y0urself y0urself commented Jul 7, 2021

What:

  • Fixing singing, --passphrase shall not have a default, especially not greenbone :trollface:
  • Remove debug print in Cmake pontos-version

Why:

How:

Checklist:

@codecov
Copy link

codecov bot commented Jul 7, 2021

Codecov Report

Merging #156 (abf23cc) into master (bd7fe1b) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #156      +/-   ##
==========================================
- Coverage   85.45%   85.43%   -0.02%     
==========================================
  Files          11       11              
  Lines         873      872       -1     
  Branches      137      137              
==========================================
- Hits          746      745       -1     
  Misses         92       92              
  Partials       35       35              
Impacted Files Coverage Δ
pontos/release/release.py 89.02% <ø> (ø)
pontos/version/cmake_version.py 85.27% <0.00%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd7fe1b...abf23cc. Read the comment docs.

@y0urself y0urself added the make release To trigger GitHub release action. label Jul 7, 2021
@y0urself y0urself marked this pull request as ready for review July 7, 2021 07:53
@y0urself y0urself requested a review from a team July 7, 2021 07:53
@y0urself y0urself changed the title Y0urself/fix signing Fix Critical Bug for pontos-release sign, remove debug print. Jul 7, 2021
@bjoernricks bjoernricks merged commit 01fce75 into master Jul 7, 2021
@bjoernricks bjoernricks deleted the y0urself/fix-signing branch July 7, 2021 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
make release To trigger GitHub release action.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants