Separate signing of tar and zipballs #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
create signing of tar and zipballs into an own command 'sign' instead of enforcing it in release.
before this commit in_project_dev was never set to false and therefore the actual project_dev change never occurs when there was a command after set PROJECT_DEV.
Codecov Report
@@ Coverage Diff @@
## master #33 +/- ##
==========================================
+ Coverage 92.34% 93.11% +0.76%
==========================================
Files 26 26
Lines 1071 1176 +105
==========================================
+ Hits 989 1095 +106
+ Misses 82 81 -1
Continue to review full report at Codecov.
|
|
I have seen, that |
y0urself
approved these changes
Sep 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Separated signing of tar and zipballs from release to a new sign command.
Fix a bug within cmakeversion that it never sets in_project_dev to false.
Why:
In some cases it makes sense to just create a release without signed zip and tars within it.
When set(PROJECT_DEV 1) was not the last command than it was never correctly set.
How:
Checklist: