Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: pontos-version golang for releases #602

Merged
merged 9 commits into from
Feb 9, 2023
Merged

Conversation

y0urself
Copy link
Member

@y0urself y0urself commented Feb 8, 2023

What

Still trying to fix go release workflow

Why

DEVOPS-533
DEVOPS-553

References

Checklist

  • Tests extended

@y0urself y0urself requested a review from a team as a code owner February 8, 2023 10:11
@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Merging #602 (8975cfb) into main (3a411e2) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #602      +/-   ##
==========================================
+ Coverage   87.78%   87.85%   +0.07%     
==========================================
  Files          70       70              
  Lines        4788     4792       +4     
  Branches      641      642       +1     
==========================================
+ Hits         4203     4210       +7     
+ Misses        419      416       -3     
  Partials      166      166              
Impacted Files Coverage Δ
pontos/github/actions/core.py 90.32% <ø> (ø)
pontos/github/actions/event.py 97.87% <100.00%> (ø)
pontos/version/go.py 94.73% <100.00%> (+9.44%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file is created if it doesn't exists.

>>> from pathlib import Path
>>> p = Path("remove.me")
>>> p.exists()
False
>>> p.write_text("some content", encoding="utf8")
12
>>> p.exists()
True

maybe create its parent directories first?

@y0urself
Copy link
Member Author

y0urself commented Feb 8, 2023

The file is created if it doesn't exists.

maybe create its parent directories first?

Still thinking about what your comment is related to ... :/

@y0urself y0urself force-pushed the y0urself/rearange-order branch from a61efee to 079125e Compare February 8, 2023 21:57
@y0urself y0urself enabled auto-merge (squash) February 8, 2023 22:02
Tom Ricciuti and others added 3 commits February 8, 2023 23:04
@y0urself y0urself merged commit 51fbe6f into main Feb 9, 2023
@y0urself y0urself deleted the y0urself/rearange-order branch February 9, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants