Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge prepare and release CLI #643

Merged
merged 5 commits into from
Feb 28, 2023
Merged

Merge prepare and release CLI #643

merged 5 commits into from
Feb 28, 2023

Conversation

bjoernricks
Copy link
Contributor

What

Merge pontos-release prepare into pontos-release release.

With the merger no changelog is written to the disk anymore. If this becomes necessary again it may be introduced with an additional CLI argument easily.

Why

Avoid the unnecessary extra prepare step which is actually only used for local testing purposes. For this use case the --local argument got introduced as a replacement.

References

DEVOPS-586

Checklist

  • Tests

Drop
```
 # Changelog

All notable changes to this project will be documented in this file.
```
Add --release-type, --local and --conventional-commits-config to release
CLI. This will allow to merge the prepare functionality into release.
Extend the release CLI to include the functionality of the prepare CLI.
With this change no intermediate prepare command is required to create a
release anymore.

Additionally no changelog file is written to the disk anymore.

To test the release it is possible to run release locally by adding the
`--local` argument where only commits and tags are created but not
pushed to a remote repo and no release is published at GitHub.
The functionality of the prepare CLI got merged into release and is
obsolete now.
@bjoernricks bjoernricks requested a review from a team as a code owner February 28, 2023 07:44
@bjoernricks bjoernricks enabled auto-merge (rebase) February 28, 2023 07:44
@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Merging #643 (ccc2ee7) into main (7d794b3) will increase coverage by 0.04%.
The diff coverage is 97.10%.

@@            Coverage Diff             @@
##             main     #643      +/-   ##
==========================================
+ Coverage   88.51%   88.55%   +0.04%     
==========================================
  Files          75       74       -1     
  Lines        4552     4492      -60     
  Branches      594      594              
==========================================
- Hits         4029     3978      -51     
+ Misses        381      372       -9     
  Partials      142      142              
Impacted Files Coverage Δ
pontos/release/release.py 98.34% <96.77%> (+12.44%) ⬆️
pontos/changelog/conventional_commits.py 100.00% <100.00%> (ø)
pontos/release/parser.py 96.61% <100.00%> (-3.39%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@y0urself y0urself disabled auto-merge February 28, 2023 08:55
@y0urself y0urself enabled auto-merge (squash) February 28, 2023 08:56
@bjoernricks bjoernricks requested a review from y0urself February 28, 2023 09:22
@y0urself y0urself merged commit d2ab17c into main Feb 28, 2023
@y0urself y0urself deleted the merge-prepare-and-release branch February 28, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants