Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Golang Version command #655

Merged
merged 3 commits into from
Mar 2, 2023
Merged

Fix Golang Version command #655

merged 3 commits into from
Mar 2, 2023

Conversation

y0urself
Copy link
Member

@y0urself y0urself commented Mar 1, 2023 •
edited
Loading

What

Change: Move version regex into static, fix regex catching version
Fix: Make sure, existing package information is not overwritten

Why

  • Catch versions like 1.1.1a1+dev1
  • Don't overwrite custom package not_main information in top of file

DEVOPS-553

Checklist

  • Tests

@y0urself y0urself force-pushed the y0urself/fix-go-version branch from bf6c8cb to 5a3605b Compare March 1, 2023 17:40
@y0urself y0urself force-pushed the y0urself/fix-go-version branch from 5a3605b to 92fd882 Compare March 1, 2023 17:47
@codecov
Copy link

codecov bot commented Mar 1, 2023 •
edited
Loading

Codecov Report

Merging #655 (7f83264) into main (a0cdc07) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #655      +/-   ##
==========================================
+ Coverage   88.72%   88.73%   +0.01%     
==========================================
  Files          73       73              
  Lines        4506     4511       +5     
  Branches      598      599       +1     
==========================================
+ Hits         3998     4003       +5     
  Misses        369      369              
  Partials      139      139
Impacted Files Coverage Δ
pontos/version/go.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@y0urself y0urself marked this pull request as ready for review March 1, 2023 17:52
@y0urself y0urself requested a review from a team as a code owner March 1, 2023 17:52
@y0urself y0urself enabled auto-merge (squash) March 1, 2023 17:52
@y0urself y0urself disabled auto-merge March 1, 2023 17:52
@y0urself y0urself enabled auto-merge (squash) March 1, 2023 17:52
@y0urself y0urself added the make release To trigger GitHub release action. label Mar 1, 2023
@y0urself y0urself disabled auto-merge March 1, 2023 19:30
@y0urself y0urself enabled auto-merge (squash) March 1, 2023 19:30
@y0urself y0urself disabled auto-merge March 1, 2023 19:30
@y0urself y0urself enabled auto-merge (squash) March 1, 2023 19:30
@y0urself y0urself disabled auto-merge March 1, 2023 19:30
@y0urself y0urself enabled auto-merge (squash) March 1, 2023 19:30
bjoernricks
bjoernricks reviewed Mar 2, 2023
View reviewed changes
Copy link
Contributor

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test case for not overriding the version file content?

@y0urself
Copy link
Member Author

y0urself commented Mar 2, 2023

Could you add a test case for not overriding the version file content?

Of course! :)

@y0urself y0urself merged commit 5a4b682 into main Mar 2, 2023
@y0urself y0urself deleted the y0urself/fix-go-version branch March 2, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoernricks bjoernricks bjoernricks approved these changes

Assignees
No one assigned
Labels
make release To trigger GitHub release action.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@y0urself @bjoernricks