Implement search for arbitrary fields

[camann9]

Currently the search command only supports search on flags. We also want search on other header fields

[camann9]

SearchKey contains a list of unimplemented search keys. We have to add them to the SearchTermBuilder

[buildscientist]

This looks to be related to this http://sourceforge.net/p/greenmail/bugs/4/

[camann9]

It actually is. At some point Marcel implemented search for flags and I recently added support for recipient and sender search. But some other fields can still not be searched. This is going to be included in 1.4.0 as soon as Marcel releases it.
There is also a unit test for this that can be extended as needed to cover additional cases.

[camann9]

@buildmaster Do you want to take this one? Probably it's pretty straightforward except for the logical operations (and/or)

[buildmaster]

presume that wasn't meant to bring me into the discussion on a repo I know nothing about. @buildscientist I'm presuming that last one was for you.

[buildscientist]

@buildmaster yes that's correct :)

@camann9 ok I'll see what I can do

[buildscientist]

Looks like these are the search fields we currently do NOT support:

• Before
• Body
• Larger
• Not
• On
• Or
• SentBefore
• SentOn
• SentSince
• Since
• Smaller
• Subject
• Text
• Uid

These were pulled from the TODO comments in SearchKey. I'll cross-reference RFC3501 Section 6.4.4 to verify we're implementing all specified fields.

Most of the work is going to be in SearchTermBuilder and SearchKey (updating that enum). I might look into refactoring ImapSearchTest. Looks like all of the search field related tests are in ImapSearchTest.testSearch().

[camann9]

Ok, Thanks :-) . Only do this if you feel like it, otherwise I'm gonna do it when I come back :-)

[buildscientist]

Do the date specific search attributes belong in SearchTermBuilder? It's not quite clear to me how we would implement date specific search attributes.

It's not clear to me why anyone would want to do a server side search of email attributes. I'm guessing IMAP is implemented as such because before broadband - downloading headers for all messages in a mailbox was fairly time consuming.

I'll leave this to @camann9 to implement as I'm somewhat confused about how to implement some of these search attributes.

[camann9]

Ok

[marcelmay]

All related issues closed => completed!