Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLANET-6638: Issues block pattern #811

Merged
merged 3 commits into from
May 9, 2022
Merged

PLANET-6638: Issues block pattern #811

merged 3 commits into from
May 9, 2022

Conversation

GP-Dan-Tovbein
Copy link
Contributor

@GP-Dan-Tovbein GP-Dan-Tovbein commented Mar 15, 2022 •
edited
Loading

Ref: https://jira.greenpeace.org/browse/PLANET-6638

Design: Figma

Demo page

Testing
Go to the instance > Create new page > Click on "+" > Search Issues pattern

There are some UI pattern's limitations, that is why we add some styles through an external CSS file (see the class deep-dive-topic class)

@GP-Dan-Tovbein GP-Dan-Tovbein added Review UAT needed This PR requires User Acceptance Tests before merge labels Mar 15, 2022
@GP-Dan-Tovbein GP-Dan-Tovbein self-assigned this Mar 15, 2022
@GP-Dan-Tovbein GP-Dan-Tovbein force-pushed the PLANET-6638_issues_block_pattern branch from 6eed58b to 0483e0a Compare March 22, 2022 19:05
planet-4 added a commit to greenpeace/planet4-test-nix that referenced this pull request Mar 22, 2022
@planet-4
greenpeace/planet4-plugin-gutenberg-blocks#811 at 0483e0ad
8b2a845 
/unhold 3090ffd5-73f8-4e4a-a067-e86245ab5e16
@GP-Dan-Tovbein GP-Dan-Tovbein force-pushed the PLANET-6638_issues_block_pattern branch from 0483e0a to 313e3bb Compare March 22, 2022 20:17
planet-4 added a commit to greenpeace/planet4-test-nix that referenced this pull request Mar 22, 2022
@planet-4
greenpeace/planet4-plugin-gutenberg-blocks#811 at 313e3bba
1ddc5ac 
/unhold 1dce8ae9-42db-4dde-bde4-5c108d1e859f
@GP-Dan-Tovbein GP-Dan-Tovbein force-pushed the PLANET-6638_issues_block_pattern branch from 313e3bb to 1f7b55f Compare March 22, 2022 20:53
planet-4 added a commit to greenpeace/planet4-test-nix that referenced this pull request Mar 22, 2022
@planet-4
greenpeace/planet4-plugin-gutenberg-blocks#811 at 1f7b55f9
591ba28 
/unhold 019be66a-64e1-4d29-9985-09fef9154bfd
@GP-Dan-Tovbein GP-Dan-Tovbein force-pushed the PLANET-6638_issues_block_pattern branch from 1f7b55f to 4a56bb9 Compare March 22, 2022 20:56
planet-4 added a commit to greenpeace/planet4-test-nix that referenced this pull request Mar 22, 2022
@planet-4
greenpeace/planet4-plugin-gutenberg-blocks#811 at 4a56bb94
d5f764d 
/unhold 33613ddd-511f-42b9-9716-b185cdf8a34e
@GP-Dan-Tovbein GP-Dan-Tovbein changed the title Issues block pattern PLANET-6638: Issues block pattern Mar 22, 2022
@GP-Dan-Tovbein GP-Dan-Tovbein force-pushed the PLANET-6638_issues_block_pattern branch from 9601635 to 4a56bb9 Compare March 23, 2022 10:54
planet-4 added a commit to greenpeace/planet4-test-sinope that referenced this pull request Mar 23, 2022
@planet-4
greenpeace/planet4-plugin-gutenberg-blocks#811 at 4a56bb94
5acb9f8 
/unhold 39644552-ed7a-4926-9bc4-b9e201decb5a
@GP-Dan-Tovbein GP-Dan-Tovbein marked this pull request as ready for review March 23, 2022 11:05
@planet-4
Copy link
Contributor

planet-4 commented Mar 23, 2022 •
edited
Loading

Test instance is ready 🚀

🌑 sinope | admin | blocks report | CircleCI | composer-local.json

⌚ 2022.05.09 12:12:41

planet-4 added a commit to greenpeace/planet4-test-sinope that referenced this pull request Mar 23, 2022
@planet-4
greenpeace/planet4-plugin-gutenberg-blocks#811 at 4a56bb94
f340506 
/unhold 9b5c405d-c338-4972-b44e-524b0eb29a37
planet-4 added a commit to greenpeace/planet4-test-sinope that referenced this pull request Mar 23, 2022
@planet-4
greenpeace/planet4-plugin-gutenberg-blocks#811 at 43553d82
5fc842d 
/unhold 0447b763-398f-49e5-8f93-a1d1b8ef94f8
@GP-Dan-Tovbein GP-Dan-Tovbein force-pushed the PLANET-6638_issues_block_pattern branch from 43553d8 to 9c85059 Compare March 23, 2022 13:31
planet-4 added a commit to greenpeace/planet4-test-sinope that referenced this pull request Mar 23, 2022
@planet-4
greenpeace/planet4-plugin-gutenberg-blocks#811 at 9c85059d
3526cec 
/unhold 4e714594-ee7e-4e03-9c04-1473a66d9dc7
@GP-Dan-Tovbein GP-Dan-Tovbein force-pushed the PLANET-6638_issues_block_pattern branch from 9c85059 to 2406828 Compare March 23, 2022 14:01
planet-4 added a commit to greenpeace/planet4-test-sinope that referenced this pull request Mar 23, 2022
@planet-4
greenpeace/planet4-plugin-gutenberg-blocks#811 at 24068289
01886d5 
/unhold 88254919-4ea2-4a79-bdd7-18f1a7fbf895
planet-4 added a commit to greenpeace/planet4-test-sinope that referenced this pull request Mar 23, 2022
@planet-4
greenpeace/planet4-plugin-gutenberg-blocks#811 at 24068289
62ce1cf 
/unhold fc785988-a382-41e1-970e-4b58f0b57ca2
@mleray
Copy link
Contributor

mleray commented Mar 24, 2022

Do we need to initialise it with so many columns? 🤔 On my local it looks a bit weird in the editor:

Screenshot 2022-03-24 at 11 45 48

planet-4 added a commit to greenpeace/planet4-test-sinope that referenced this pull request Apr 25, 2022
@planet-4
greenpeace/planet4-plugin-gutenberg-blocks#811 at 734ede8c
fad3db6 
/unhold 16deeff2-12e7-4f8e-8dee-5d9bde8a59b4
planet-4 added a commit to greenpeace/planet4-test-sinope that referenced this pull request May 2, 2022
@planet-4
greenpeace/planet4-plugin-gutenberg-blocks#811 at b9e9ff0e
a96a035 
/unhold afcaa8ae-633d-4c6e-b8cd-d93e7752cd24
planet-4 added a commit to greenpeace/planet4-test-sinope that referenced this pull request May 2, 2022
@planet-4
greenpeace/planet4-plugin-gutenberg-blocks#811 at 489572f1
d251f17 
/unhold 6b0e940b-da2d-4c5e-9e43-9068554f9ed1
planet-4 added a commit to greenpeace/planet4-test-sinope that referenced this pull request May 2, 2022
@planet-4
greenpeace/planet4-plugin-gutenberg-blocks#811 at 28eba7e6
94f96bc 
/unhold 174fa7fe-0358-489d-af4a-77b5f6b645ba
GP-Dan-Tovbein
GP-Dan-Tovbein commented May 2, 2022
View reviewed changes
admin/js/editor.js
});
});

['core/paragraph'].forEach(block => {
Copy link
Contributor Author

@GP-Dan-Tovbein GP-Dan-Tovbein May 2, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This style allows to editors to choose the Roboto font family as default.

@GP-Dan-Tovbein GP-Dan-Tovbein force-pushed the PLANET-6638_issues_block_pattern branch from 28eba7e to 1ea400d Compare May 2, 2022 16:53
planet-4 added a commit to greenpeace/planet4-test-sinope that referenced this pull request May 2, 2022
@planet-4
greenpeace/planet4-plugin-gutenberg-blocks#811 at 1ea400db
30abc07 
/unhold bb57712a-0a05-4677-9d66-5585450b1cb3
planet-4 added a commit to greenpeace/planet4-test-sinope that referenced this pull request May 2, 2022
@planet-4
greenpeace/planet4-plugin-gutenberg-blocks#811 at e6ac05d4
e3d2f3d 
/unhold e8fe0398-f0dd-4cd6-985f-4a64327aa0d5
@GP-Dan-Tovbein GP-Dan-Tovbein force-pushed the PLANET-6638_issues_block_pattern branch from e6ac05d to ff554b9 Compare May 2, 2022 20:27
planet-4 added a commit to greenpeace/planet4-test-sinope that referenced this pull request May 2, 2022
@planet-4
greenpeace/planet4-plugin-gutenberg-blocks#811 at ff554b9f
fee752f 
/unhold 74c5d454-099c-43b3-8c0d-ccf4d99ba417
@comzeradd
Copy link
Member

@dantovbein make sure to squash commits before merge.

planet-4 added a commit to greenpeace/planet4-test-sinope that referenced this pull request May 4, 2022
@planet-4
greenpeace/planet4-plugin-gutenberg-blocks#811 at 242c9672
37171ac 
/unhold c5b913fb-4982-4201-96ca-6b7d565144d7
@dantovbein
Issues pattern block
107944d 
- Implement pattern structure
- Implement Issues block as a second approach
- Register new styles
@GP-Dan-Tovbein GP-Dan-Tovbein force-pushed the PLANET-6638_issues_block_pattern branch from 242c967 to 3b5d25e Compare May 4, 2022 21:43
planet-4 added a commit to greenpeace/planet4-test-sinope that referenced this pull request May 4, 2022
@planet-4
greenpeace/planet4-plugin-gutenberg-blocks#811 at 3b5d25e9
624f69d 
/unhold 2cc84c4a-897c-4c18-84fa-895111d3f871
@dantovbein
Fix width to elements on small screens
edeef57 
- Implement stacked on mobile feature. The same functionality as columns.
@GP-Dan-Tovbein GP-Dan-Tovbein force-pushed the PLANET-6638_issues_block_pattern branch from 3b5d25e to edeef57 Compare May 4, 2022 21:48
planet-4 added a commit to greenpeace/planet4-test-sinope that referenced this pull request May 4, 2022
@planet-4
greenpeace/planet4-plugin-gutenberg-blocks#811 at edeef570
3075844 
/unhold 17ebf1ce-a1e2-4d1d-abd3-6f84be9062ad
@GP-Dan-Tovbein
Copy link
Contributor Author

GP-Dan-Tovbein commented May 4, 2022 •
edited
Loading

@Inwerpsel I've updated the style (as requested by Houssam) and it's now rendered in a better way on small and medium screens.
Screenshot 2022-05-04 at 18 59 12
Screenshot 2022-05-04 at 18 59 33

Screenshot 2022-05-04 at 18 59 03

@GP-Dan-Tovbein GP-Dan-Tovbein requested a review from Inwerpsel May 4, 2022 22:10
@dantovbein
Follow up review
1a3134d 
- Set the image to 16% (40px) of width
planet-4 added a commit to greenpeace/planet4-test-sinope that referenced this pull request May 5, 2022
@planet-4
greenpeace/planet4-plugin-gutenberg-blocks#811 at 1a3134df
e360dcf 
/unhold d705bc33-ac2d-4bd7-894c-35761c3ba5b8
@GP-Dan-Tovbein GP-Dan-Tovbein added UAT Passed User Acceptance Tests passed and removed UAT needed This PR requires User Acceptance Tests before merge labels May 6, 2022
@GP-Dan-Tovbein
Copy link
Contributor Author

@Inwerpsel FYI, Houssam has approved the UAT! So, let me know if this PR is fine again!

@GP-Dan-Tovbein GP-Dan-Tovbein dismissed mleray’s stale review May 9, 2022 12:03

It happened in a previous version of this implementation.

@GP-Dan-Tovbein GP-Dan-Tovbein merged commit b43c018 into master May 9, 2022
@GP-Dan-Tovbein GP-Dan-Tovbein deleted the PLANET-6638_issues_block_pattern branch May 9, 2022 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Inwerpsel Inwerpsel Inwerpsel approved these changes

@comzeradd comzeradd Awaiting requested review from comzeradd

@mleray mleray Awaiting requested review from mleray

Assignees

@GP-Dan-Tovbein GP-Dan-Tovbein

Labels
Review [Test Env] sinope UAT Passed User Acceptance Tests passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@GP-Dan-Tovbein @planet-4 @mleray @Inwerpsel @comzeradd @dantovbein