Remove 99 from Relationship to HoH picklist #1014

gigxz · 2024-12-31T20:18:43Z

Description

Remove Data Not Collected as an option when selecting the Relationship To HoH for a new or existing Enrollment. 99 is not a valid selection per the HUD HMIS data dictionary. However it is valid per the CSV Export, so we retain it as a valid option for display only.

Testing instructions are on the issue https://github.com/open-path/Green-River/issues/7127

Related Warehouse PR (Does not depend on): greenriver/hmis-warehouse#5028

Type of change

Bug fix / HUD Compliance fix

Checklist before requesting review

I have performed a self-review of my code
I have run the code that is being changed under ideal conditions, and it doesn't fail
My code includes comments and/or descriptive variable names to help other engineers understand the intent (or not applicable)
My code follows the style guidelines of this project (eslint)
I have updated the documentation (or not applicable)
If it's not obvious how to test this change, I have provided testing instructions in this PR or the related issue

src/modules/household/components/EditHouseholdMemberTable.tsx

gigxz · 2025-01-10T14:56:23Z

src/modules/household/components/EditHouseholdMemberTable.tsx

@@ -109,21 +106,6 @@ const EditHouseholdMemberTable = ({
    });
  }, [currentMembers]);

-  // If new members have beed added highlight their relationship field if it's DNC


This is no longer needed, because it's not permitted to add a household member without specifying a valid RelationshipToHoH.

The existing "highlight" behavior is retained whereby when you change the HoH, the RelationshipToHoH field for other members is highlighted, to indicate that you should review those and update them if they are no longer accurate.

Cool, I like the new inference behavior. There are still some edge cases with inference that I guess we might refine later. For example, in a household like this:

A, HoH

B, Spouse

C, Other Relative

When changing HoH from A to C, B stays marked as "Spouse" but should probably be inferred to now be "Other Relative." I think this is not in scope for this PR though - looks like that would be a backend change.

@martha Good point, it would be possible to make some additional inferences! Currently the highlight is supposed to nudge the user to review those, and I think it's OK to stick to that existing behavior for now.

gigxz · 2025-01-10T15:00:43Z

src/modules/household/components/elements/RelationshipToHohSelect.tsx

-          ? HmisEnums.RelationshipToHoH[value]
-          : 'Select relationship',
-      }}
+      textInputProps={{ placeholder: 'Select Relationship', ...textInputProps }}


If an existing Enrollment has null or 99 for Relationship To HoH, it appears like this on the Enrollment dashboard Household tab:

And Edit Household:

martha · 2025-01-10T19:41:37Z

src/modules/projects/components/tables/ProjectHouseholdsTable.tsx

-            whiteSpace='nowrap'
-          />
-        ))}
+        {hh.householdClients.map((c) =>


@gigxz could you give more info about why you reverted this? I'm seeing missing "Data Not Collected" info on the table:

Edit: It looks like this would be resolved in the Tables deploy branch, anyway: https://github.com/greenriver/hmis-frontend/pull/1020/files#diff-819ec0ace67cab35cca989ef6e3f3d5a6187dec26e6dcbcb1d4090614788a6c5R43-R53

I didn't change the current behavior here, enrollments with null/99 relationship to hoh still appear like they do in your screenshot (confirmed in staging environments which appear the same). On a previous version I had removed DataNotCollected from the Enum entirely, which is why you see that commit history, but I reverted that change.

martha · 2025-01-10T19:46:32Z

src/modules/household/components/EditHouseholdMemberTable.tsx

@@ -109,21 +106,6 @@ const EditHouseholdMemberTable = ({
    });
  }, [currentMembers]);

-  // If new members have beed added highlight their relationship field if it's DNC


Cool, I like the new inference behavior. There are still some edge cases with inference that I guess we might refine later. For example, in a household like this:

A, HoH

B, Spouse

C, Other Relative

When changing HoH from A to C, B stays marked as "Spouse" but should probably be inferred to now be "Other Relative." I think this is not in scope for this PR though - looks like that would be a backend change.

ttoomey

Looks good!

ttoomey · 2025-01-10T16:56:50Z

src/modules/form/util/formUtil.ts

 export const localResolvePickList = (
  pickListReference: string,
  excludeDataNotCollected = false
 ): PickListOption[] | null => {
  if (isHmisEnum(pickListReference)) {
    let values = Object.entries(HmisEnums[pickListReference]);
-    if (excludeDataNotCollected) {
+
+    if (excludeDataNotCollected || pickListReference === 'RelationshipToHoH') {


Nice docs!
Rather than hard-coding this in the utility fn, would it be much more trouble to make this the caller's responsibility?

localResolvePickList(pickListReference, pickListReference === 'RelationshipToHoH')

Yeah, the issue is that when a DynamicForm renders an item with picklist reference RelationshipToHoH, we also want to exclude 99 from that list. DynamicField uses the usePickList hook to resolve pick lists, which in turn uses localResolvePickList. So I figured it makes more sense to just hard-code it into the local resolution logic, rather than passing it through from multiple callers.

In practice, its' the picklist that appears when you are enrolling a new client: https://github.com/greenriver/hmis-warehouse/blob/24060527d5f707d337e36894f213b181df7dcfc6/drivers/hmis/lib/form_data/default/fragments/new_enrollment_details.json#L53

src/modules/household/components/elements/RelationshipToHohSelect.tsx

Remove 99 from relationship picklist

2115461

gigxz mentioned this pull request Dec 31, 2024

Infer new RelationshipToHoH when changing HoH greenriver/hmis-warehouse#5028

Merged

10 tasks

Merge branch 'release-147' into gig/7127-disallow-99-relationship

878d33b

gigxz changed the base branch from release-146 to release-147 January 9, 2025 17:39

gigxz added 3 commits January 9, 2025 12:54

Move to frontend

1f4d8ff

Exclude HoH from picklist

c89a1ae

Revert changes

00c88eb

gigxz commented Jan 9, 2025

View reviewed changes

src/modules/household/components/EditHouseholdMemberTable.tsx Show resolved Hide resolved

Merge branch 'release-147' into gig/7127-disallow-99-relationship

5f56d4e

gigxz commented Jan 10, 2025

View reviewed changes

gigxz changed the title ~~Remove 99 from relationship picklist~~ Remove 99 from Relationship to HoH picklist Jan 10, 2025

gigxz marked this pull request as ready for review January 10, 2025 15:06

gigxz requested review from ttoomey and martha January 10, 2025 15:08

martha approved these changes Jan 10, 2025

View reviewed changes

ttoomey approved these changes Jan 10, 2025

View reviewed changes

Address feedback

54cbeca

gigxz merged commit f10d4fe into release-147 Jan 10, 2025
3 checks passed

gigxz deleted the gig/7127-disallow-99-relationship branch January 10, 2025 20:51

martha mentioned this pull request Jan 13, 2025

Follow up on QA items for Table Actions deploy branch #1021

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove 99 from Relationship to HoH picklist #1014

Remove 99 from Relationship to HoH picklist #1014

gigxz commented Dec 31, 2024 •

edited

Loading

gigxz Jan 10, 2025 •

edited

Loading

martha Jan 10, 2025

gigxz Jan 10, 2025

gigxz Jan 10, 2025

martha Jan 10, 2025

gigxz Jan 10, 2025 •

edited

Loading

martha Jan 10, 2025

ttoomey left a comment

ttoomey Jan 10, 2025

gigxz Jan 10, 2025

gigxz Jan 10, 2025

Remove 99 from Relationship to HoH picklist #1014

Remove 99 from Relationship to HoH picklist #1014

Conversation

gigxz commented Dec 31, 2024 • edited Loading

Description

Type of change

Checklist before requesting review

gigxz Jan 10, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gigxz Jan 10, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ttoomey left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gigxz commented Dec 31, 2024 •

edited

Loading

gigxz Jan 10, 2025 •

edited

Loading

gigxz Jan 10, 2025 •

edited

Loading