7058-input-validation #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prevent non-numeric values
5 tasks
ttoomey
commented
Dec 5, 2024
| const [errorMessage, setErrorMessage] = useState<string | null>(null); | ||
|
|
||
| const currencyInputProps = currency |
There was a problem hiding this comment.
replaced with MUI's InputAdornment
|
@gigxz per our discussion I've replaced the custom key handler with react-number-format |
gigxz
approved these changes
Dec 9, 2024
| ) : undefined, | ||
| ...InputProps, | ||
| }} | ||
| {...(props as any)} |
There was a problem hiding this comment.
It seems like NumericFormat actually does handle the typing correctly s-yadav/react-number-format#577
but we run into issues where TextInputProps differ from NumericFormat props. The below keeps typescript happy without the cast:
defaultValue={(defaultValue || '') as string}
type={type as any}
{...props}
(pulling out defaultValue and type from the props object)
There was a problem hiding this comment.
I pushed it since I had it locally anyway: f0721bb lmk what you think!
There was a problem hiding this comment.
that's a nice improvement, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prevent non-numeric values
Description
GH Issue
Related warehouse issue for backend validation
Restrict numeric inputs to numeric characters. Adds
react-number-formatto avoid the complexities of scrubbing user input. Also supports commasType of change
Testing
should exercise the multitude of keyboard entries:
See testing instructions in the wh PR
Checklist before requesting review