Fix for using new find_safely (#5109)

greenriver · Feb 4, 2025 · 1a7b606 · 1a7b606
1 parent a9b62bc
commit 1a7b606
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/app/controllers/notification_configurations_controller.rb b/app/controllers/notification_configurations_controller.rb
@@ -53,11 +53,14 @@ def destroy
   helper_method :import_threshold
 
   def notification_configuration
-    @notification_configuration ||= GrdaWarehouse::NotificationConfiguration.find_safely(params[:id]) ||
+    @notification_configuration ||= if params[:id].present?
+      GrdaWarehouse::NotificationConfiguration.find_safely(params[:id])
+    else
       GrdaWarehouse::NotificationConfiguration.new(
         source: import_threshold,
         notification_slug: import_threshold.valid_notification_slug(params[:notification_slug]),
       )
+    end
   end
   helper_method :notification_configuration
 end