-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix disable_transitions.js injection so transitions actually get disabled #4735
Conversation
assert_text 'Save & Submit' # Unlock succeeded | ||
end | ||
|
||
def submit_household_assessment | ||
find('button', text: 'Save & Submit').trigger('click') # note: using click_button fails on CI (#6619) | ||
click_button 'Save & Submit' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can easily reproduce the fix here. The SaveSlide
component at the bottom of the assessment was sliding in, which was causing click_button not to work. Now that the transitions are disabled, it no longer slides in, so this works
Note that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks for tracking that down! The extensions
option seems much cleaner too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great 🙏
Please squash merge this PR
Description
The previous code was not actually disabling transitions (confirmed in debug mode). This change appears to actually disable them
Type of change
Checklist before requesting review