Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disable_transitions.js injection so transitions actually get disabled #4735

Merged
merged 5 commits into from
Sep 24, 2024

Conversation

gigxz
Copy link
Contributor

@gigxz gigxz commented Sep 23, 2024

Please squash merge this PR

Description

The previous code was not actually disabling transitions (confirmed in debug mode). This change appears to actually disable them

Type of change

  • Bug fix

Checklist before requesting review

  • I have performed a self-review of my code
  • I have run the code that is being changed under ideal conditions, and it doesn't fail
  • My code includes comments and/or descriptive variable names to help other engineers understand the intent (or not applicable)
  • My code follows the style guidelines of this project (rubocop)
  • I have updated the documentation (or not applicable)
  • If it's not obvious how to test this change, I have provided testing instructions in this PR or the related issue

Verified

This commit was signed with the committer’s verified signature.
gigxz Gig

Verified

This commit was signed with the committer’s verified signature.
gigxz Gig

Verified

This commit was signed with the committer’s verified signature.
gigxz Gig
@gigxz gigxz changed the base branch from release-134 to release-135 September 23, 2024 20:35

Verified

This commit was signed with the committer’s verified signature.
gigxz Gig
@gigxz gigxz requested review from ttoomey and martha September 23, 2024 20:37
assert_text 'Save & Submit' # Unlock succeeded
end

def submit_household_assessment
find('button', text: 'Save & Submit').trigger('click') # note: using click_button fails on CI (#6619)
click_button 'Save & Submit'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can easily reproduce the fix here. The SaveSlide component at the bottom of the assessment was sliding in, which was causing click_button not to work. Now that the transitions are disabled, it no longer slides in, so this works

@gigxz
Copy link
Contributor Author

gigxz commented Sep 24, 2024

Note that ReferenceError: _cuprite is not defined still appears, this fixes a separate issue.
https://github.com/greenriver/hmis-warehouse/actions/runs/11002006286/job/30547991954

Verified

This commit was signed with the committer’s verified signature.
gigxz Gig
@gigxz gigxz marked this pull request as ready for review September 24, 2024 12:52
Copy link
Contributor

@ttoomey ttoomey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for tracking that down! The extensions option seems much cleaner too

Copy link
Contributor

@martha martha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 🙏

@gigxz gigxz merged commit 4bfd9e4 into release-135 Sep 24, 2024
50 of 51 checks passed
@gigxz gigxz deleted the gig/system-test-stability-2 branch September 24, 2024 15:35
@gigxz gigxz mentioned this pull request Jan 6, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants