Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HMIS test date usage, remove TIME_FMT #5004

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Conversation

gigxz
Copy link
Contributor

@gigxz gigxz commented Dec 16, 2024

Merging this PR

  • use the squash-merge strategy for PRs targeting a release-X branch
  • use a merge-commit or rebase strategy for PRs targeting the stable branch

Description

  • Remove the TIME_FMT thing because there were warnings about repeated declarations and we don't need it
  • Update some tests to use the pattern of setting today/yesterday as vars to use throughout the test, so they are more robust to running near midnight

Type of change

Cleanup

Checklist before requesting review

  • I have performed a self-review of my code
  • I have run the code that is being changed under ideal conditions, and it doesn't fail
  • If adding a new endpoint / exposing data in a new way, I have:
    • ensured the API can't leak data from other data sources
    • ensured this does not introduce N+1s
    • ensured permissions and visibility checks are performed in the right places
  • I have updated the documentation (or not applicable)
  • I have added spec tests (or not applicable)
  • I have provided testing instructions in this PR or the related issue (or not applicable)

@gigxz gigxz marked this pull request as ready for review December 17, 2024 13:42
@gigxz gigxz requested review from martha and ttoomey December 17, 2024 13:43
Copy link
Contributor

@martha martha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you

Copy link
Contributor

@ttoomey ttoomey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for making the assessment test more reliable

@gigxz gigxz merged commit 67d4db4 into release-145 Dec 17, 2024
54 checks passed
@gigxz gigxz deleted the gig/hmis-test-dates branch December 17, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants