Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Split Households mutation #5089

Merged
merged 64 commits into from
Feb 11, 2025
Merged

Implement Split Households mutation #5089

merged 64 commits into from
Feb 11, 2025
+423 −1

Conversation

martha
Copy link
Contributor

@martha martha commented Jan 27, 2025 •
edited
Loading

Merging this PR

  • use the squash-merge strategy for PRs targeting a release-X branch

Description

GH issue: https://github.com/open-path/Green-River/issues/5800

Summary of changes:

  • Add the Split Household mutation
  • Add spec and system tests

Type of change

New feature

Checklist before requesting review

  • I have performed a self-review of my code
  • I have run the code that is being changed under ideal conditions, and it doesn't fail
  • If adding a new endpoint / exposing data in a new way, I have:
    • ensured the API can't leak data from other data sources
    • ensured this does not introduce N+1s
    • ensured permissions and visibility checks are performed in the right places
  • [n/a] Any major architectural changes are supported by an approved ADR (Architectural Decision Record)
  • [n/a] I have updated the documentation (or not applicable)
  • I have added spec tests (or not applicable)
  • I have provided testing instructions in this PR or the related issue (or not applicable)

martha and others added 27 commits January 6, 2025 17:07
@martha
Fix erroneous deletion
b514eba
@martha
Revert "Fix erroneous deletion"
fff4369 
This reverts commit b514eba.
@martha @gigxz
Fix spec tests for table actions (#5012)
c14a4f4 
* Fix spec tests

* Correct spec

* Fix spec

* Fix spec tests for table actions

* PR feedback (wip)

* Use aria label directly

* Remove repetition of sys tests

---------

Co-authored-by: Gig <[email protected]>
@martha
Sketch join households mutation
0aee665
@martha
Keep conflicting enrollment validation on backend
8fece60
@martha
Return both receiving and donor household
940df46
@martha
Fix bugs and add spec
3524490
@martha
Revert unused schema updates
68a8b98
@martha
Add system tests
adf3cac
@martha
Add unit update logic
eca913f
@martha
Add missing default
427d529
@martha
Add event history table
a6bad7a
@martha
Fix test failures (hopefully)
bc87e46
@martha
Restructure and add comments
cefa537
@martha
Merge branch 'deploy/6761-table-actions' into martha/5752-join-hh
22082a7
@martha
Merge branch 'release-149' into deploy/6761-table-actions
1a4e3c9
@martha
Merge branch 'deploy/6761-table-actions' into martha/5752-join-hh
7b00cfb
@martha
Avoid n+1 on household, hopefully
171fc5d
@martha
Renames for consistency and compatibilitY
d4887ee
@martha
Move enrollment snapshot method somewhere common
1cba85f
@martha
Revert system test rerun
590f66f
@martha
Fix aria labels after refactor
7d91c36
@martha
Implement Split Households mutation
443abb9
@martha
Remove errant todo
f2c8189
@martha
Add permission restriction
ba6cc8f
@martha
Add permission restriction
91a979d
@martha
Merge branch 'martha/5752-join-hh' into martha/5800-split-hh
7b640b4
@martha martha marked this pull request as ready for review January 27, 2025 19:53
@martha martha requested a review from gigxz January 27, 2025 19:53
@martha martha mentioned this pull request Jan 27, 2025
Merged
10 tasks
@martha martha requested a review from gigxz February 10, 2025 12:57
gigxz
gigxz approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@gigxz gigxz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the system test! 💯

Base automatically changed from martha/5752-join-hh to release-152 February 11, 2025 19:33
@martha martha merged commit ae36b16 into release-152 Feb 11, 2025
53 of 54 checks passed
@martha martha deleted the martha/5800-split-hh branch February 11, 2025 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gigxz gigxz gigxz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martha @gigxz