Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix N+1 on household reminders query #5102

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Conversation

gigxz
Copy link
Contributor

@gigxz gigxz commented Feb 3, 2025

Merging this PR

  • use the squash-merge strategy for PRs targeting a release-X branch
  • use a merge-commit or rebase strategy for PRs targeting the stable branch

Description

Issue: https://github.com/open-path/Green-River/issues/6980

Fix perf issue that was surfaced in sentry in QA.

Add data loading and regression test. The frontend loads the intake/exit assessment for each enrollment with a reminder.

It could probably be improved so that the relevant assessment (if any) is loaded directly on the reminder. But this change fixes the performance problem while preserving the existing api.

Type of change

Checklist before requesting review

  • I have performed a self-review of my code
  • I have run the code that is being changed under ideal conditions, and it doesn't fail
  • If adding a new endpoint / exposing data in a new way, I have:
    • ensured the API can't leak data from other data sources
    • ensured this does not introduce N+1s
    • ensured permissions and visibility checks are performed in the right places
  • Any major architectural changes are supported by an approved ADR (Architectural Decision Record)
  • I have updated the documentation (or not applicable)
  • I have added spec tests (or not applicable)
  • I have provided testing instructions in this PR or the related issue (or not applicable)

//: # NOTE: system tests may fail if there is no branch on the hmis-frontend that matches the Source or Target branch of this PR. This is expected

@gigxz gigxz requested a review from ttoomey February 3, 2025 16:38
Copy link
Contributor

@ttoomey ttoomey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks!

@gigxz gigxz merged commit 1ad5529 into release-150 Feb 3, 2025
53 of 54 checks passed
@gigxz gigxz deleted the gig/6980-performance-fix branch February 3, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants