Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add picklist ADMIN_AVAILABLE_UNITS_FOR_ENROLLMENT for AC unit changes #5111

Merged
merged 11 commits into from
Feb 5, 2025

Conversation

gigxz
Copy link
Contributor

@gigxz gigxz commented Feb 4, 2025

Merging this PR

  • use the squash-merge strategy for PRs targeting a release-X branch
  • use a merge-commit or rebase strategy for PRs targeting the stable branch

Description

Issue: https://github.com/open-path/Green-River/issues/7236

  • Add a new picklist for units available for an enrollment. unlike the current AVAILABLE_UNITS_FOR_ENROLLMENT picklist, it also includes units with different unit types. This is quite customer specific, it is needed for a new Occurrence Point form they will use to allow admins to change unit type, which will cut down on support burden.

Opened against #5022 so I could test the features together, but it's not actually dependent

Type of change

new feature

Checklist before requesting review

  • I have performed a self-review of my code
  • I have run the code that is being changed under ideal conditions, and it doesn't fail
  • If adding a new endpoint / exposing data in a new way, I have:
  • Any major architectural changes are supported by an approved ADR (Architectural Decision Record)
  • I have updated the documentation (or not applicable)
  • I have added spec tests (or not applicable)
  • I have provided testing instructions in this PR or the related issue (or not applicable)

@gigxz gigxz marked this pull request as ready for review February 4, 2025 22:17
@gigxz gigxz requested a review from ttoomey February 4, 2025 22:17
Copy link
Contributor

@ttoomey ttoomey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

drivers/hmis/app/graphql/types/forms/pick_list_option.rb Outdated Show resolved Hide resolved
drivers/hmis/app/graphql/types/forms/pick_list_option.rb Outdated Show resolved Hide resolved
Base automatically changed from gig/7093-fix-duplicate-occurrence-point-bug to release-151 February 5, 2025 12:54
@gigxz gigxz merged commit b0eaa4a into release-151 Feb 5, 2025
54 checks passed
@gigxz gigxz deleted the gig/7093-admin-unit-picklist branch February 5, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants