Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional RRH Sub Type Adjustments #5116

Merged
merged 2 commits into from
Feb 7, 2025
Merged

Additional RRH Sub Type Adjustments #5116

merged 2 commits into from
Feb 7, 2025

Conversation

eanders
Copy link
Contributor

@eanders eanders commented Feb 6, 2025 •
edited
Loading

Merging this PR

  • use the squash-merge strategy for PRs targeting a release-X branch

Description

  • Updates some key Project and SHE scopes to handle RRH with RRH Sub Types
  • Adds RRH sub-type and project type to the projects on the client history calendar

Type of change

  • New feature

Checklist before requesting review

  • I have performed a self-review of my code
  • I have run the code that is being changed under ideal conditions, and it doesn't fail
  • I have added spec tests (or not applicable)
  • I have provided testing instructions in this PR or the related issue (or not applicable)

@eanders eanders requested a review from dtgreiner February 7, 2025 16:49
@eanders eanders merged commit 1a678a9 into release-151 Feb 7, 2025
54 checks passed
@eanders eanders deleted the ea/rrh-sub-type-additional branch February 7, 2025 17:36
gigxz
gigxz reviewed Feb 10, 2025
View reviewed changes
app/models/grda_warehouse/hud/project.rb
@@ -76,44 +76,92 @@ class Project < Base
# Needs to come after has_many :enrollments, bc one extension uses a has_many through: :enrollments relation
include RailsDrivers::Extensions

# A scope to return any projects that are residential (provide housing). Generally, and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a comment about why Street Outreach is included? It will always confuse me that it's considered residential in the codebase, since docs describe Street Outreach projects as specifically providing non- facility-based care.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, guess I was too late

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can do!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gigxz does this suffice?
d713fb2

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gigxz gigxz gigxz left review comments

@dtgreiner dtgreiner dtgreiner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eanders @gigxz @dtgreiner