Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed failed to connect #612 #614

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Fixed failed to connect #612 #614

merged 1 commit into from
Oct 22, 2024

Conversation

TheDuffman85
Copy link
Contributor

@TheDuffman85 TheDuffman85 commented Oct 21, 2024

Fixed failed to connect #612 . Replaced requests with httpx in order to be able to use HTTP/2.

@AdrianGarside
Copy link
Collaborator

AdrianGarside commented Oct 21, 2024

@TheDuffman85 This is awesome work to find a solution so quickly. Please add back the comments you deleted and I'll complete the PR and run a new dev build.

@AdrianGarside
Copy link
Collaborator

Also a required validation is failing:
Error: R] [MANIFEST] Manifest keys are not sorted correctly: domain, name, then alphabetical order

requirements must be before ssdp

@TheDuffman85
Copy link
Contributor Author

Sure no problem.

@TheDuffman85
Copy link
Contributor Author

Done

@trevorstuart24
Copy link

trevorstuart24 commented Oct 22, 2024

i change the code as duffman suggested but when trying to add the integration again i get the error: Config flow could not be loaded: {"message":"Invalid handler specified"}

edit: pre-release worked

@AdrianGarside AdrianGarside merged commit 1d103ad into greghesp:develop Oct 22, 2024
2 checks passed
@vordenken
Copy link

I installed the pre-release containing this fix but for me its not working:

Unable to install package httpx==0.27.2: ERROR: Cannot install httpx==0.27.2 because these package versions have conflicting dependencies. ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/topics/dependency-resolution/#dealing-with-dependency-conflicts

@ArikShemesh
Copy link

pre-release v2.0.23-dev3 worked for me without any issue.

@TheDuffman85
Copy link
Contributor Author

@ArikShemesh it was working fine with HA 2024.10 but failed with previous versions.

nzrutman pushed a commit to nzrutman/ha-bambulab that referenced this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants