More scipy/pykdtree test wrangling #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcomer
commented
Dec 2, 2023
| @@ -49,6 +47,7 @@ def test_natural_earth_custom(): | |||
| return ax.figure | |||
|
|
|||
|
|
|||
| @pytest.mark.skipif(not _HAS_PYKDTREE_OR_SCIPY, reason='pykdtree or scipy is required') | |||
There was a problem hiding this comment.
This skip would be unnecessary if the test didn't use stock_img, which I don't think the test really needs. However I'm not sure it's worth replacing the test's reference image for the purpose of this exercise.
|
Thanks @rcomer! I definitely just took the heavy handed approach without worrying too much about whether tests were able to be run or not. But, this is nicer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Hi @greglucas, here is a review for SciTools#2282 in PR form! I found a few tests in these modules can still pass without scipy or pykdtree, so I think it makes sense to move the skip down to the function level. By the time I figured out how it could work it seemed easiest to push my own branch.
Apart from a tiny conflict where the ruff change moved an import, the rest looks good to me.
Implications