Compatibility with ImageMagick 7 #360
Conversation
- change `convert` to `magick` and `compare` to `magick compare` - change order of arguments to put input file before operations - in computation of diff, remove "-background white -flatten" but I do not know why
|
Did you test these changes against earlier versions of ImageMagik to see if they were backwards compatible? |
|
No, sorry -- what's the earliest version you want to support? |
|
(And what version do you use?) |
|
I'm using 6.9.13-21, though I'm now noticing for the first time that this is now considered legacy and 7 is now production. I have not been tracking ImageMagick development. I don't have time to do it tonight, but let me see about upgrading my ImageMagick installation and seeing how things go from there before we make any decisions about what versions we should support. |
|
Looks good in version 6.9.13: 
And version 7.1.1: 
But since the two versions want to be called in different ways, it should be an environment variable, so this is not ready to merge. |
|
Done, hopefully that works with both versions now. |
davidweichiang
changed the title
- change `convert` to `magick` and `compare` to `magick compare` - change order of arguments to put input file before operations - in computation of diff, remove "-background white -flatten" but I do not know why
These were the changes I needed to make to get the test script working (tested with 7.1.1-43):
converttomagickandcomparetomagick compare. This was just to silence the warning that was printed every timeconvertwas run.-background white -flatten, but I admittedly have no idea why. As it was, the output of-compose difference -compositewas empty, and the final diff did not look right.