Goes with #1608 #364
Merged
Goes with #1608 #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Okay, on this I've got just 8 failed tests and they all make sense to me: gabc-dump/glyphs/high-bars (all 4 variants) fail due to inconsequential changes in the lyric font. This is a regular occurrence due to changes in how LuaTeX renders fonts being updated. tex-output/bugs/fix-1139 These test are expected failures due to the changes in how we place a 2-line initial. In all cases I'm happy accepted the new results and then declaring this new feature good to go. |
Since we changed how we positioned a 2-line initial, these tests have to be updated to reflect those changes.
Small changes in how fonts are rendered.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gregorio-project/gregorio#1608
These are the tests from #358 but added to a fresh copy of the develop branch.