A fix for fs.WatchFile delays #38
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mtime so we can poll more quickly
|
Thanks for the submission @cardboardfox. I will have a look at this in more depth this week and get back to you. |
|
I'm pretty sure the log file gets rotated at some point. I'm not sure if it would happen while the client is running, or only between sessions, but I think it would be best to handle that case too. |
losttime
reviewed
Apr 10, 2019
| @@ -3,7 +3,8 @@ import path from 'path'; | |||
|
|
|||
| export default function (log) { | |||
| let defaultOptions = { | |||
| endOfLineChar: os.EOL | |||
| endOfLineChar: os.EOL, | |||
| fsPollInterval: 250 | |||
There was a problem hiding this comment.
My personal preference would be to have the watch poll slightly less frequently. The data isn't super time-sensitive (though it would be nice to have sooner to better plan a next move) so I'd prefer not to have the additional overhead.
Maybe something like?:
Suggested change
| fsPollInterval: 250 | |
| fsPollInterval: 1250 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed some lag between an event occurring in Hearthstone and being presented in Farseer. On closer inspection, it seems that fs.WatchFile has a default polling rate of 5007 milliseconds. I added an option with a lower default polling time of 250 (if that's too fast, it can be changed to something more reasonable.)
I saw that some code had been added to prevent duplicate events from firing off fs.WatchFile, which seems to be a known bug, but realized since the Hearthstone output log only grows, we could instead monitor fs.Stats' size property to see if we're looking at the same event.